Set y limit to zero for representative line plots, and try to fix pre…

…-commit type checking
EdmundGoodman · Apr 7, 2024 · 19f6288 · 19f6288
1 parent bcc450b
commit 19f6288
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -59,6 +59,7 @@ repos:
     hooks:
       - id: mypy
         args: ["--scripts-are-modules"]
+        additional_dependencies: ["pydantic==2.6.4", "textual==0.51.0"]
         # verbose: true
 
   # Run the vulture dead code detection tool

diff --git a/src/hpc_multibench/plot/plot_matplotlib.py b/src/hpc_multibench/plot/plot_matplotlib.py
@@ -41,6 +41,7 @@ def draw_line_plot(
     plt.xlabel(plot.x)
     plt.ylabel(plot.y)
     plt.title(plot.title)
+    plt.ylim(0)
     plt.show()
 
 

diff --git a/src/hpc_multibench/plot/plot_plotext.py b/src/hpc_multibench/plot/plot_plotext.py
@@ -31,6 +31,7 @@ def draw_line_plot(
     this_plt.theme(PLOTEXT_THEME)
     this_plt.xlabel(plot.x)
     this_plt.ylabel(plot.y)
+    this_plt.ylim(0)
     this_plt.title(plot.title)
 
 

diff --git a/src/hpc_multibench/yaml_model.py b/src/hpc_multibench/yaml_model.py
@@ -44,10 +44,10 @@ def realise(
             for key, value in instantiation.items():
                 # TODO: Error checking on keys
                 if key == "sbatch_config":
-                    run.sbatch_config.update(value)  # type: ignore
+                    run.sbatch_config.update(value)
                 # TODO: Further root cause why this was causing duplicate runs
                 # elif key == "environment_variables":
-                #     run.environment_variables.update(value)  # type: ignore
+                #     run.environment_variables.update(value)
                 else:
                     setattr(run, key, value)