Add bity reporting #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peachbits
commented
Apr 30, 2020
Use PAGE_SIZE constant Change inputAmount to a number
paullinator
approved these changes
Apr 30, 2020
| @@ -28,12 +29,12 @@ async function fetchBity (swapFuncParams: SwapFuncParams) { | |||
| if (!swapFuncParams.useCache) { | |||
| console.log('Fetching Bity from JSON...') | |||
| } | |||
| let diskCache = { txs: [] } | |||
| let diskCache = { txs: [], offset: {lastCheckedMonth: queryMonth, lastCheckedYear: queryYear} } | |||
There was a problem hiding this comment.
lastCheckedMonth and lastCheckedYear can go directly into diskCache, no need for the offset object
| @@ -91,9 +92,16 @@ async function fetchBity (swapFuncParams: SwapFuncParams) { | |||
| newTransactions.push(ssTx) | |||
| } | |||
|
|
|||
| if (monthlyTxs.length < 100 && queryMonth === todayMonth && queryYear === todayYear) { | |||
| if (monthlyTxs.length < PAGE_SIZE && queryMonth === todayMonth && queryYear === todayYear) { | |||
| if (queryMonth === '1') { | |||
There was a problem hiding this comment.
This logic belongs on line 116. You shouldnt assign the diskCache in the middle of your inner loop. Instead, do it before assigning diskCache into the out object.
Also, you really should create addMonth/subMonth functions. This will clean up and make your inner loop much more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.