Skip to content
This repository has been archived by the owner on Mar 19, 2022. It is now read-only.

Linting #41

Open
gptkrsh opened this issue Nov 8, 2021 · 16 comments
Open

Linting #41

gptkrsh opened this issue Nov 8, 2021 · 16 comments

Comments

@gptkrsh
Copy link

gptkrsh commented Nov 8, 2021

Add linting to the project.

Example: https://github.com/EddieHubCommunity/LinkFree

@StarTrooper08
Copy link

Is that eslint file to be added?
If yes can I work on this issue!!

@gptkrsh
Copy link
Author

gptkrsh commented Nov 8, 2021

Is that eslint file to be added?
If yes can I work on this issue!!

Yeas, also add a linting workflow, plus fix the linting issues if any.

@EmmaDawsonDev
Copy link
Member

Do you still want to be assigned @StarTrooper08 ?

@StarTrooper08
Copy link

Nope I m working side by side😅.
So I might take more 1-2 days.

@EmmaDawsonDev
Copy link
Member

@StarTrooper08 no worries, just let us know if you do want to work on it

@StarTrooper08
Copy link

I have setup the project but haven't started yet .
But I'll make one PR till tomorrow.

@gptkrsh
Copy link
Author

gptkrsh commented Nov 16, 2021

I have setup the project but haven't started yet . But I'll make one PR till tomorrow.

Take your time 😄

@StarTrooper08
Copy link

In which format should I keep eslint file (json or yml)?

@StarTrooper08
Copy link

image

I have done this much what should I do next?

@gptkrsh
Copy link
Author

gptkrsh commented Nov 17, 2021

In which format should I keep eslint file (json or yml)?

JS I think.

@gptkrsh
Copy link
Author

gptkrsh commented Nov 17, 2021

image

I have done this much what should I do next?

How about we copy paste the config from the LinkFree Repo 🙂

@StarTrooper08
Copy link

image

Did the following changes.

@StarTrooper08
Copy link

Should I make PR now?
And yes when creating PR I should ignore package.json files right?

@gptkrsh
Copy link
Author

gptkrsh commented Nov 17, 2021

Should I make PR now? And yes when creating PR I should ignore package.json files right?

don't ignore package files (eslint is a new dep)

@StarTrooper08
Copy link

ok

@StarTrooper08
Copy link

Created pull request #66

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants