feat: WIP

Author: oxyno-zeta

internal/controller/postgresql/postgres/database.go

@@ -10,6 +10,7 @@ const (
 	CascadeKeyword                = "CASCADE"
 	RestrictKeyword               = "RESTRICT"
 	CreateDBSQLTemplate           = `CREATE DATABASE "%s" WITH OWNER = "%s"`
+	ChangeDBOwnerSQLTemplate      = `ALTER DATABASE "%s" OWNER TO "%s"`
 	IsDatabaseExistSQLTemplate    = `SELECT 1 FROM pg_database WHERE datname='%s'`
 	RenameDatabaseSQLTemplate     = `ALTER DATABASE "%s" RENAME TO "%s"`
 	CreateSchemaSQLTemplate       = `CREATE SCHEMA IF NOT EXISTS "%s" AUTHORIZATION "%s"`
@@ -75,6 +76,20 @@ func (c *pg) CreateDB(dbname, role string) error {
 	return nil
 }
 
+func (c *pg) ChangeDBOwner(dbname, owner string) error {
+	err := c.connect(c.defaultDatabase)
+	if err != nil {
+		return err
+	}
+
+	_, err = c.db.Exec(fmt.Sprintf(ChangeDBOwnerSQLTemplate, dbname, owner))
+	if err != nil {
+		return err
+	}
+
+	return nil
+}
+
 func (c *pg) CreateSchema(db, role, schema string) error {
 	err := c.connect(db)
 	if err != nil {

internal/controller/postgresql/postgres/postgres.go

@@ -17,6 +17,7 @@ type SetRoleOnDatabaseRoleSetting struct {
 
 type PG interface { //nolint:interfacebloat // This is needed
 	CreateDB(dbname, username string) error
+	ChangeDBOwner(dbname, owner string) error
 	IsDatabaseExist(dbname string) (bool, error)
 	RenameDatabase(oldname, newname string) error
 	CreateSchema(db, role, schema string) error

internal/controller/postgresql/postgresqldatabase_controller_test.go

@@ -458,6 +458,20 @@ var _ = Describe("PostgresqlDatabase tests", func() {
 		Expect(stillExists).To(BeTrue())
 	})
 
+	It("should be ok to recover a wrong database owner", func() {
+		// Create pgec
+		setupPGECWithAllowGrantAdminOption("10s", false)
+
+		// Create pgdb
+		item := setupPGDB(true)
+
+		Expect(item.Status.Ready).To(BeTrue())
+		Expect(item.Status.Phase).To(Equal(postgresqlv1alpha1.DatabaseCreatedPhase))
+		Expect(item.Status.Database).To(Equal(pgdbDBName))
+
+		// Change db owner to
+	})
+
 	It("should be ok to have a pgdb with a pgec with allow grant admin option on roles", func() {
 		// Create pgec
 		setupPGECWithAllowGrantAdminOption("10s", false)
@@ -2024,7 +2038,6 @@ var _ = Describe("PostgresqlDatabase tests", func() {
 		oldExists, oldErr := isSQLDBExists(pgdbDBName + "-old")
 		Expect(oldErr).ToNot(HaveOccurred())
 		Expect(oldExists).To(BeFalse())
-
 	})
 
 	It("should be ok to delete it with wait and nothing linked", func() {

internal/controller/postgresql/suite_test.go

@@ -1099,6 +1099,24 @@ func disconnectConnFromKey(key string) error {
 	return nil
 }
 
+func changeDBOwner(dbname, role string) error {
+	if mainDBConn == nil {
+		db, err := sql.Open("postgres", postgresUrl)
+		if err != nil {
+			return err
+		}
+		mainDBConn = db
+	}
+
+	sqlTemplate := `ALTER DATABASE "%s" OWNER TO "%s"`
+	_, err := mainDBConn.Exec(fmt.Sprintf(sqlTemplate, dbname, role))
+	if err != nil {
+		return err
+	}
+
+	return nil
+}
+
 func isRoleOwnerofSQLDB(dbname, role string) (bool, error) {
 	// Query template
 	IsRoleOwnerOfDbSQLTemplate := `SELECT 1 FROM pg_catalog.pg_database d WHERE d.datname = '%s' AND pg_catalog.pg_get_userbyid(d.datdba) = '%s';`