Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 5 compatibility #104

Open
AcerxX opened this issue Nov 27, 2019 · 8 comments
Open

Symfony 5 compatibility #104

AcerxX opened this issue Nov 27, 2019 · 8 comments

Comments

@AcerxX
Copy link

AcerxX commented Nov 27, 2019

Hello,

When trying to update the app to symfony 5 I get the following dependency error:

Problem 1
- Conclusion: don't install symfony/console v5.0.0
- Conclusion: don't install symfony/console v5.0.0-RC1
- Conclusion: don't install symfony/console v5.0.0-BETA2
- Installation request for easycorp/easy-deploy-bundle dev-master -> satisfiable by easycorp/easy-deploy-bundle[dev-master].
- Conclusion: don't install symfony/console v5.0.0-BETA1
- Conclusion: don't install symfony/console 5.1.x-dev
- easycorp/easy-deploy-bundle dev-master requires symfony/console ~2.3|~3.0|~4.0 -> satisfiable by symfony/console[2.3.x-dev, 2.4.x-dev, 2.5.x-dev, 2.6.x-dev, 2.7.x-dev, 2.8.x-dev, 3.0.x-dev, 3.1.x-dev, 3.2.x-dev, 3.3.x-dev, 3.4.x-dev, 4.0.x-dev, 4.1.x-dev, 4.2.x-dev, 4.3.x-dev, 4.4.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 3.4.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 4.3.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 4.4.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 2.3.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 2.4.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 2.5.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 2.6.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 2.7.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 2.8.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 3.0.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 3.1.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 3.2.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 3.3.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 4.0.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 4.1.x-dev].
- Can only install one of: symfony/console[5.0.x-dev, 4.2.x-dev].
- Installation request for symfony/console 5.* -> satisfiable by symfony/console[5.0.x-dev, 5.1.x-dev, v5.0.0, v5.0.0-BETA1, v5.0.0-BETA2, v5.0.0-RC1].

Thanks.

@daum
Copy link

daum commented Jan 20, 2020

Looks like this should be resolved once #103 is merged.

@COil
Copy link

COil commented Jan 30, 2020

Hello, a new tag 1.0.6 has been released, can you test and close this ticket if it's OK.

@94noni
Copy link

94noni commented Apr 16, 2020

I deployed with success an sf5 app on prod today

It took me time and some internet digging & code digging, but it works finally


here is my deploy file, if it can help:

<?php

use EasyCorp\Bundle\EasyDeployBundle\Configuration\Option;
use EasyCorp\Bundle\EasyDeployBundle\Deployer\DefaultDeployer;

return new class extends DefaultDeployer
{
    public function configure()
    {
        return $this->getConfigBuilder()
            // uses my internal SSH config ~/.ssh/config file
            ->server('my-server-ssh-config')
            ->deployDir('/var/www/my-website')
            ->repositoryUrl('[email protected]:user/repo.git')
            ->repositoryBranch('master')
            ->useSshAgentForwarding(false) // SSH key exists on production server
            ->keepReleases(3)
            ->sharedFilesAndDirs(['.env', '.env.local', 'var/log', 'public/uploads'])
            ->writableDirs(['var/cache/', 'var/log/', 'public/uploads/'])
            ->dumpAsseticAssets(false) // usage of Yarn instead
        ;
    }

    public function beforeStartingDeploy()
    {
        $this->log('Local checks');
        $this->runLocal('make lint'); // run locally some linters via the Makefile
    }

    public function beforePublishing()
    {
        $this->log('Remote yarn');
        $this->runRemote('yarn install');
        $this->runRemote('yarn run build');

        $this->log('Remote composer dump env prod');
        $this->runRemote(sprintf('%s dump-env prod', $this->getConfig(Option::remoteComposerBinaryPath)));

        $this->log('Remote migration');
        $this->runRemote('{{ console_bin }} doctrine:migration:migrate --no-interaction --allow-no-migration');

        $this->log('Remote cache clear');
        $this->runRemote('{{ console_bin }} cache:clear');
    }

    public function beforeFinishingDeploy()
    {
        $this->log('Remote Restarting servers');
        $this->runRemote('/etc/init.d/nginx restart');
        $this->runRemote('/etc/init.d/php7.4-fpm restart');
    }
};

ℹ️ before the first deploy to work, i had to:

  • make a first deploy, it initialises the /releases and /shared folders on prod server
  • manually copy the .env and a production ready filled .env.local file in the /shared folder
  • then launch a final deploy -v and it works :)

Cheers

@maathieu
Copy link

Looking forward to official Symfony 5 support!

@COil
Copy link

COil commented Apr 23, 2020

What do you mean?

@maathieu
Copy link

Currently in the documentation Symfony 5 is not listed as compatible:

"Your application: it can use any version of Symfony (2.7+, 3.x, 4.x)."

@COil
Copy link

COil commented Apr 28, 2020

But it is, I am using it with Symfony 5 already on multiples projects. May be, it's the doc that isn't correct. Feel free to submit a PR please. :)

@noniagriconomie
Copy link

noniagriconomie commented Apr 29, 2020

@maathieu cc @COil PR opened (with my pro github account)

maybe this issue can be closed after :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants