Fix error when docker-image-common.yml runs on new tag#3140
Merged
samsrabin merged 3 commits intoMay 20, 2025
Conversation
samsrabin
added
b4b
samsrabin
changed the title
samsrabin
commented
May 20, 2025
samsrabin
commented
May 20, 2025
samsrabin
changed the title
ekluzek
approved these changes
May 20, 2025
ekluzek
left a comment
ekluzek
left a comment
Contributor
There was a problem hiding this comment.
This looks right to me as well. The pathname fix is obviously required. And I looked at the change by hand, and think it makes sense to me, in removing the newline from the tagnames.
The one thing I wonder about though -- do we WANT the workflow to run on both push to master and the tag made immediately afterwards? And do we want it to run on push to b4b-dev? I'll let you think on that and decide, so approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: Tested in a separate repository and it works!