-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add encode/decodeValueType
as public callable methods
#325
Conversation
we need to update the docs as well, when we do this change |
Ready to merge - just waiting for conflict fix and docs update: https://github.com/ERC725Alliance/erc725.js/blob/develop/docs/classes/ERC725.md |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #325 +/- ##
===========================================
- Coverage 83.71% 83.50% -0.21%
===========================================
Files 18 17 -1
Lines 1130 1134 +4
Branches 255 258 +3
===========================================
+ Hits 946 947 +1
+ Misses 98 97 -1
- Partials 86 90 +4 ☔ View full report in Codecov by Sentry. |
@@ -766,86 +975,6 @@ myErc725.decodeMappingKey( | |||
|
|||
--- | |||
|
|||
## encodePermissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hugoo this has not been deleted, just move at the top to sort function names correctly by alphabetical order.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
Feature
What is the current behaviour (you can also link to an open issue here)?
The methods
encodeValueType
anddecodeValueType
are currently not available as public method part of the ERC725 class.These methods can be useful to encode certain LSP2 value type raw. For example, a
uin128
(For LSP2 Array length) to obtain an exactly 16 bytes long value.What is the new behaviour (if this is a feature change)?
Make this method part of the class, so that they can be called and used.
Other information: