Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: change LSP3 to SupportedStandards:LSP3Profile #307

Merged
merged 4 commits into from
Aug 15, 2023

Conversation

YamenMerhi
Copy link
Contributor

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

  • Change SupportedStandards:LSP3UniversalProfile to SupportedStandards:LSP3Profile:

    • Change KeyName
    • Change Key
    • Change valueContent
  • Change the name of the JSON to LSP3ProfileMetadata.json

Other information:

Check here for context: lukso-network/LIPs#220

Do not release until lsp-smart-contract is released

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Merging #307 (4bb83aa) into develop (122efa9) will increase coverage by 0.85%.
Report is 61 commits behind head on develop.
The diff coverage is 89.77%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop     #307      +/-   ##
===========================================
+ Coverage    83.04%   83.89%   +0.85%     
===========================================
  Files           18       18              
  Lines          979     1124     +145     
  Branches       218      252      +34     
===========================================
+ Hits           813      943     +130     
- Misses          91       97       +6     
- Partials        75       84       +9     
Files Changed Coverage Δ
src/lib/getData.ts 89.79% <ø> (ø)
src/lib/provider-wrapper-utils.ts 88.88% <ø> (-0.59%) ⬇️
src/lib/decodeMappingKey.ts 84.21% <60.00%> (-5.54%) ⬇️
src/lib/utils.ts 83.12% <76.92%> (-0.77%) ⬇️
src/lib/decodeData.ts 81.81% <83.33%> (+0.91%) ⬆️
src/provider/providerWrapper.ts 81.25% <90.00%> (-1.65%) ⬇️
src/lib/encoder.ts 83.95% <91.66%> (+6.04%) ⬆️
src/constants/constants.ts 100.00% <100.00%> (ø)
src/constants/interfaces.ts 100.00% <100.00%> (ø)
src/index.ts 77.22% <100.00%> (+0.22%) ⬆️
... and 3 more

... and 4 files with indirect coverage changes

@Hugoo Hugoo merged commit 73f3481 into ERC725Alliance:develop Aug 15, 2023
This was referenced May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants