Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How Should Typos and Spelling Errors Be Dealt With? #4

Open
DoNotUseGitHub opened this issue Sep 22, 2023 · 1 comment
Open

How Should Typos and Spelling Errors Be Dealt With? #4

DoNotUseGitHub opened this issue Sep 22, 2023 · 1 comment

Comments

@DoNotUseGitHub
Copy link
Contributor

I ran a quick codespell on the quests repo and found a ton of spelling errors.

If these spelling errors or typos were found on Al'Kabor EQMac, they should be left in place, correct? I assume the quest dialog was copy and pasted from logs taken before EQMac was shutdown, and that these typos or spelling errors found in quest dialog weren't user errors on our part.

For example, do we correct the word "organiztion" to "organization" in the case of Kane Bayle's quest dialogue:

e.self:Say("Why, of course! I would love to contibute to your esteemed organiztion. I would just hate to see the Knights of Thunder crumble. What would ever happen to Qeynos if their noble order were gone?! Perish the thought!");

Or "lightening" to "lightning" for Shayna Thunderhand:

e.self:Say("The druids chanted around their hierophant, who held their order's sacred item. As they chanted, they brought forth the great blanket of silver clouds upon the horizon. The rangers, rogues, and bards in their musical chant ushered in the raging winds that guided the druids' clouds over the forest. It was the duty of the veterans, the warriors and knights, to call forth the thunder and begin the broiling of the storm. Toliara and her order then began an arcane chant. She raised the scepter upwards to the sky and collectively, the small order wove a single spell that arched from the scepter and struck the center of the tempest that responded in a great display of lightening and rain. Until the rise of the next dawn, the ceremonies continued -- each order respectively praising Karana. By the rise of second dawn and the end of the solstice celebrations, the [Order of the Storm Caller] was inducted into the ranks of Karana's faithful.");

Or Kael Sentinels "silenty" watching you to "silently":

e.self:Emote("silenty watches you.");

What about inconsistent use of punctuation like doesnt for example?

e.self:Say("Huh? Don't you know better than to interrupt a Coldain enjoying his ale? I may be a user of priestly magic but that doesnt mean I can't bash your head in.");

There are obviously false positives due to troll, ogre, dwarf, pirate, and other roleplay speech, NPC names, but in general there are quite a few commonly misspelled words found in quest dialogue. If that is how it was on Al'Kabor then my understanding is it should be left untouched?

Thoughts and opinions?

@regneq
Copy link
Contributor

regneq commented Sep 25, 2023

You can probably go on live and check. If it founds to be misspelled. you can just go ahead and do a pull request on each quest. We can check log to see if there is any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants