[Bug Fix] Fix Corpses "Disappearing" #4275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes corpses "disappearing" by fixing the graveyard check. Prior to the corpse overhaul (#3938), moving corpses to graveyards was assumed successful and automatically removed from the process. Note: Will open a separate issue for the graveyard timer handling. ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) # Testing Attach images and describe testing done to validate functionality. Clients tested: RoF2 # Checklist - [x] I have tested my changes - [x] I have performed a self-review of my code. Ensuring variables, functions and methods are named in a human-readable way, comments are added only where naming of variables, functions and methods can't give enough context. - [x] I own the changes of my code and take responsibility for the potential issues that occur
Akkadius
approved these changes
Apr 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes corpses "disappearing" by fixing the graveyard check. Prior to the corpse overhaul (#3938), moving corpses to graveyards was assumed successful and automatically removed from the process. Even in non-graveyard zones, it was attempting to move the corpse to the graveyard and removing them from the process.
Note: Opened a separate issue for the graveyard timer handling. See #4276.
Type of change
Testing
Post-graveyard timer in PoK (non-graveyard zone). Corpse remains.
Pre-graveyard move in PoD (graveyard zone).
Post-graveyard move in PoD. Corpse moved to graveyard.
Second graveyard timer cycle in PoD. Corpse remains. Note: Location move and rez timer reset tied to other issue mentioned above.
Clients tested: RoF2
Checklist