Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uplynk.com breaks video #738

Closed
terrorist96 opened this issue Feb 4, 2016 · 11 comments
Closed

uplynk.com breaks video #738

terrorist96 opened this issue Feb 4, 2016 · 11 comments
Labels
broken site help wanted yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage

Comments

@terrorist96
Copy link
Contributor

http://wwmt.com/news/local/new-legislation-would-allow-concealed-carry-without-a-permit

Need to move the following to yellow in order to fix video:
content.uplynk.com
content-aeui1.uplynk.com
stg-ec-ore-u.uplynk.com

@cooperq
Copy link
Contributor

cooperq commented Feb 5, 2016

I am unable to test this because I don't have flash enabled. I believe your solution would work though. The problem is that uplynk is definitely being used to track and serve targeted ads. I would not be suprised to learn that they use flash LSO's to track, which our cookie blocking does not currently prevent. I am unable to find any privacy policy for uplynk either.
Right now I am not comfortable with adding uplynk to the yellow list at this time.

@cooperq
Copy link
Contributor

cooperq commented Feb 5, 2016

Perhaps I would be comfortable adding them to the yellow list if we added functionality to block LSOs

@cooperq
Copy link
Contributor

cooperq commented Feb 6, 2016

Actually this seems like a really good candidate for #400

@terrorist96
Copy link
Contributor Author

Just posting another example:

http://abc30.com/news/fresno-law-enforcement-leaders-speak-out-against-proposed-gun-control-measure/1342975/#videoplayer

storage, content, content-ausc2, and stg-ec-ore-u.uplynk.com all need to be yellowlisted to fix the video.

@terrorist96
Copy link
Contributor Author

http://fox23maine.com/news/local/nra-takes-aim-at-question-3-in-maine

To fix video, yellowlist:
content.uplynk.com
content-aeuf2.uplynk.com
stg-ec-norcal-u.uplynk.com

@terrorist96
Copy link
Contributor Author

http://wgme.com/news/local/no-on-3-sign-vandalized-in-york-county

The following need to be on the yellowlist to fix the video:
content.uplynk.com
content-aeuf1.uplynk.com
stg-ec-ore-u.uplynk.com

@alexristich
Copy link
Contributor

@cooperq Should uplynk.com be added to the cookieblock list? Looks like it's a CDN which is owned by Verizon, so seems like a good candidate.

@cooperq
Copy link
Contributor

cooperq commented Sep 28, 2016

Sure. @alexristich can you submit a pull request?

@terrorist96
Copy link
Contributor Author

@cooperq I took care of it.
#943 and #944

@terrorist96
Copy link
Contributor Author

Can you confirm if I did it right? Do I have to edit both the regular and legacy files? Does a separate PR need to be done for the FF version?

@cooperq
Copy link
Contributor

cooperq commented Sep 28, 2016

@terrorist96 you did it right! You do need to edit both files, you do not need a seperate PR for firefox. good job, and thanks!

@cooperq cooperq closed this as completed Sep 28, 2016
@ghostwords ghostwords added the yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken site help wanted yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage
Projects
None yet
Development

No branches or pull requests

4 participants