Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GATT server "Insufficient Encryption Key Size" tests are invalid #82

Open
sjanc opened this issue Mar 28, 2023 · 0 comments
Open

GATT server "Insufficient Encryption Key Size" tests are invalid #82

sjanc opened this issue Mar 28, 2023 · 0 comments

Comments

@sjanc
Copy link

sjanc commented Mar 28, 2023

Tests that verify GATT server "Insufficient Encryption Key Size" error code have couple issues:

  1. they verify wrong ATT status code : should be ATT_ERROR_INSUFFICIENT_ENCRYPTION_KEY_SIZE (0x0c) instead of ATT_ERROR_INSUFFICIENT_ENCRYPTION (0x0f)
  2. tests should pair with proper (small) key size before accessing characteristics and verifying returned status code

1 is easy to fix, 2 I have no idea on how this should be done, there is pairing_bv_01_c() which seems to be unused and this is only indication of pairing in those tests (unless I miss something)

This is affecting following tests:
GATT/SR/GAR/BI-11-C [Insufficient Encryption Key Size error - Reading Using Characteristic UUID]
GATT/SR/GAR/BI-17-C [Insufficient Encryption Key Size error - Reading Long Characteristic Value]
GATT/SR/GAR/BI-22-C [Insufficient Encryption Key Size error - Reading Multiple Characteristic Values]
GATT/SR/GAW/BI-06-C [Insufficient Encryption Key Size error - Writing Characteristic Value]
GATT/SR/GAW/BI-13-C [Insufficient Encryption Key Size error - Writing Long Characteristic Value]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant