Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework conditions #71

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Rework conditions #71

wants to merge 4 commits into from

Conversation

Fizzadar
Copy link
Contributor

@Fizzadar Fizzadar commented Oct 8, 2020 •
edited
Loading

WIP! New conditions implementation that actually makes sense:

name: my-project
configVersion: 1
requireKubetools: '~=12.0'  # optional, replacement for minKubetoolsVersion

deployments:
  app-name:
    conditions:
      dev:  true  # default
      test: true  # default
      deploy:
        - env: 'production'
          namespace: 'A'
        - env: 'backup'
          namespace: 'B'

Closes: #64

Nick Barrett added 2 commits October 8, 2020 10:48
Implement requireKubetools config variable and configVersion.
53bcf71 
This replaces `minKubetoolsVersion` (maintaining backwards compatibility)
and enables tracking of config version.
Implement new style conditions for config v1.
3497a65 
Based on the discussion @ #64.
@Fizzadar Fizzadar self-assigned this Oct 8, 2020
Nick Barrett added 2 commits October 9, 2020 14:37
Rename env -> context everywhere.
6ba897a 
This maintains backwards compatibility by passing the old `KUBE_ENV`
environment variable as before, in additino to the new `KUBE_CONTEXT`.

The move makes "context" the consistent method by which a target cluster
is chosen - this is entirely a deploy tooling specific thing as K8s
clusters don't have names. This means that the use of context and the
`KUBE_CLUSTER` envvar are at the discretion of the individual or team
using the tool as a way to differentiate between multiple clusters.
Add tests for the condition checking logic.
22c5169
@Fizzadar Fizzadar marked this pull request as ready for review October 9, 2020 13:43
@Fizzadar Fizzadar marked this pull request as draft November 10, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fizzadar Fizzadar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework/improve conditions
1 participant
@Fizzadar