Skip to content

[FE] refactor and add routing in App.js #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2023
Merged

[FE] refactor and add routing in App.js #61

merged 2 commits into from
Nov 5, 2023

Conversation

karishma-shah
Copy link
Contributor

@karishma-shah karishma-shah commented Nov 4, 2023 •
edited by PaulaPerdomo
Loading

Closes #78

This PR refactors App.js and adds routing to App.js making it easier to test different webpages with different paths. It also adds the main routing logic to App.js.

There is no UI changes here, but please test that things are still functional.

Steps to test:

  1. checkout this branch
  2. run npm install
  3. run npm start

tmahabir
tmahabir approved these changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@tmahabir tmahabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! lgtm!

Note: I think we'll have to use { Outlet, Link } from "react-router-dom" once we add more routes

@karishma-shah karishma-shah merged commit 552cc5c into main Nov 5, 2023
@PaulaPerdomo PaulaPerdomo added infrastructure For the initial setup frontend For frontend developments labels Nov 8, 2023
@PaulaPerdomo PaulaPerdomo added this to the Milestone 4 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmahabir tmahabir tmahabir approved these changes

Assignees

@karishma-shah karishma-shah

Labels
frontend For frontend developments infrastructure For the initial setup
Projects
None yet
Milestone
Milestone 4
Development

Successfully merging this pull request may close these issues.

[Infra][Frontend] Add routing to App.js
3 participants
@karishma-shah @tmahabir @PaulaPerdomo