Skip to content

Navbar component #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2023
Merged

Navbar component #50

merged 5 commits into from
Nov 4, 2023

Conversation

karishma-shah
Copy link
Contributor

@karishma-shah karishma-shah commented Oct 30, 2023

Closes #75

This PR adds the Navbar component that will be used as the header of every page. It shows different options depending on if the user is authenticated or not. Since we don't have the auth service setup yet, I'm using the useState hook to keep track of the user temporarily.

It also fixes the styling for the sortBy component to match Figma designs.

Here is a visual diff - notice the routing and collapsed view:

Screen.Recording.2023-10-30.at.5.08.39.PM.mov
Screen.Recording.2023-10-31.at.2.36.33.PM.mov

To test this locally:

  1. checkout this branch
  2. run npm install
  3. run npm start
  4. go to localhost:3000

@ECE444-2023Fall ECE444-2023Fall deleted a comment from divyaK15 Oct 31, 2023
Copy link
Contributor

@tmahabir tmahabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Just the two comments :)

Copy link
Contributor

@tmahabir tmahabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@karishma-shah karishma-shah merged commit ea280cb into main Nov 4, 2023
@PaulaPerdomo PaulaPerdomo added feature New feature or request frontend For frontend developments labels Nov 8, 2023
@PaulaPerdomo PaulaPerdomo added this to the Milestone 4.5 milestone Nov 8, 2023
@PaulaPerdomo PaulaPerdomo changed the title [FE] Navbar component Navbar component Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request frontend For frontend developments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Add Navbar component
3 participants