Skip to content

Add the favourite icon to postCard #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2023
Merged

Add the favourite icon to postCard #49

merged 3 commits into from
Oct 31, 2023

Conversation

karishma-shah
Copy link
Contributor

@karishma-shah karishma-shah commented Oct 30, 2023 •
edited by PaulaPerdomo
Loading

Closes #74

This PR adds the favourite icon to every PostCard component in the bottom right corner.

Here is a visual:

Screen.Recording.2023-10-30.at.2.45.27.PM.mov

To test locally:

  1. checkout this branch
  2. run npm install
  3. run npm start
  4. go to localhost:3000

tmahabir
tmahabir approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@tmahabir tmahabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Make sure to resolve conflicts when merging :)

@karishma-shah karishma-shah merged commit cfc334e into main Oct 31, 2023
@PaulaPerdomo PaulaPerdomo added the frontend For frontend developments label Nov 8, 2023
@PaulaPerdomo PaulaPerdomo added this to the Milestone 4.5 milestone Nov 8, 2023
@PaulaPerdomo PaulaPerdomo added the feature New feature or request label Nov 8, 2023
@PaulaPerdomo PaulaPerdomo changed the title [FE] [feat] Add the favourite icon to postCard Add the favourite icon to postCard Nov 8, 2023
@karishma-shah karishma-shah self-assigned this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmahabir tmahabir tmahabir approved these changes

Assignees

@karishma-shah karishma-shah

Labels
feature New feature or request frontend For frontend developments
Projects
None yet
Milestone
Milestone 4.5
Development

Successfully merging this pull request may close these issues.

[Frontend] Add favourite icon to postcard
3 participants
@karishma-shah @tmahabir @PaulaPerdomo