Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Gtable from Struct to Type Alias #5

Open
DylanMeeus opened this issue Aug 29, 2020 · 2 comments
Open

Refactor Gtable from Struct to Type Alias #5

DylanMeeus opened this issue Aug 29, 2020 · 2 comments
Labels
good first issue Good for newcomers

Comments

@DylanMeeus
Copy link
Owner

Gtable is just a lightweight wrapper around []float64 at the moment.
This can be refactored into a type Gtable []float64 alias. Or, even better perhaps, type Table []float64 to represent any kind of table (guard table / wave table).

@DylanMeeus DylanMeeus added the good first issue Good for newcomers label Aug 29, 2020
@JavascriptMick
Copy link

interested in contributing, not sure if this is still a good issue to start with? seems a bit pointless

@DylanMeeus
Copy link
Owner Author

Hi,

This is more a "quality of life" improvement. Mainly to help the type system clarify exactly what our types represent. It's indeed pretty low-hanging fruit and does not have the largest impact. If there's another issue you are interested in, I can help you get started on those as well. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants