Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The display position of ripple of Hamburger button is misaligned #814

Open
matsudamper opened this issue Feb 6, 2019 · 4 comments
Open

The display position of ripple of Hamburger button is misaligned #814

matsudamper opened this issue Feb 6, 2019 · 4 comments
Labels
bug Something isn't working welcome contribute

Comments

@matsudamper
Copy link

Overview (Required)

  • The display position of ripple of Hamburger button is misaligned

Steps To Reproduce

  1. launch app
  2. Press Hamburger button

Expected behavior
Do not display ripple or shift ripple to the left.

Screenshots
screenshot_20190206-221152

Example shifted to the left
screenshot_20190207-020930

Env:

  • Device: Pixel3
  • OS: 9.0
  • App Version or the branch master

Additional context
@matsudamper matsudamper added the bug Something isn't working label Feb 6, 2019
@takahirom
Copy link
Member

Thanks for reporting 👍

@matsudamper
Copy link
Author

I will do it.🙌
However, I do not know whether to shift Ripple to the left or hide.
I think that it is better not to have ripple.

@takahirom
Copy link
Member

@matsudamper Do you have any idea for that?

@matsudamper
Copy link
Author

I think that It is better to delete ripple.
Because there is no ripple in the Play Store etc. I think that it is better than misaligned.

@matsudamper matsudamper reopened this Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working welcome contribute
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@takahirom @matsudamper