Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White space appeared when scrolling and rotating in sessions page #327

Open
gen0083 opened this issue Feb 13, 2017 · 5 comments
Open

White space appeared when scrolling and rotating in sessions page #327

gen0083 opened this issue Feb 13, 2017 · 5 comments

Comments

@gen0083
Copy link
Contributor

gen0083 commented Feb 13, 2017

Overview (Required)

  • white space appeared when scrolling and rotating combination.

Reproduce step

  1. scroll down to session's position started at 11:50
  2. rotate the device
  3. scroll up a little
  4. rotate the device again
  5. scroll up to top of the sessions then white space appeared

Links

Screenshot

ezgif com-video-to-gif

@konifar
Copy link
Contributor

konifar commented Feb 13, 2017

It looks TwoWayView bug 😢

@KeithYokoma
Copy link
Contributor

Similar bug when you launch the app in landscape mode and then rotate to portrait 😢

@jmatsu
Copy link
Contributor

jmatsu commented Feb 13, 2017

Ah sorry, actually it's not twoway-view bug. 🐍
The hight of recycler view is fixed because of fixing another bug.
We need to reinit the height when configuration is changed.

binding.recyclerView.getLayoutParams().height = binding.root.getHeight() - binding.border.getHeight() - binding.headerRow.getHeight();

@KeithYokoma
Copy link
Contributor

Got it!

@konifar
Copy link
Contributor

konifar commented Feb 13, 2017

Understood! Thanks! 👍

@konifar konifar added this to the 0.1.0 milestone Feb 13, 2017
@konifar konifar added the ready label Feb 14, 2017
@konifar konifar modified the milestone: 0.1.0 Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants