perf(sync): Improve PermissionV1 parsing

This increased parsing performance by 3 times on old devices and around 2 times in newer devices

Author: Iamlooker

sync/fdroid/src/main/kotlin/com/looker/sync/fdroid/common/IndexConverter.kt

@@ -5,6 +5,8 @@ import com.looker.sync.fdroid.v1.model.IndexV1
 import com.looker.sync.fdroid.v1.model.Localized
 import com.looker.sync.fdroid.v1.model.PackageV1
 import com.looker.sync.fdroid.v1.model.RepoV1
+import com.looker.sync.fdroid.v1.model.maxSdk
+import com.looker.sync.fdroid.v1.model.name
 import com.looker.sync.fdroid.v2.model.AntiFeatureV2
 import com.looker.sync.fdroid.v2.model.CategoryV2
 import com.looker.sync.fdroid.v2.model.FeatureV2

sync/fdroid/src/main/kotlin/com/looker/sync/fdroid/common/JsonParser.kt

@@ -5,4 +5,5 @@ import kotlinx.serialization.json.Json
 val JsonParser = Json {
     ignoreUnknownKeys = true
     coerceInputValues = true
+    isLenient = true
 }

sync/fdroid/src/main/kotlin/com/looker/sync/fdroid/v1/model/PackageV1.kt

@@ -4,21 +4,8 @@ package com.looker.sync.fdroid.v1.model
 * PackageV1, PermissionV1 are licensed under the GPL 3.0 to FDroid Organization.
 * */
 
-import kotlinx.serialization.KSerializer
 import kotlinx.serialization.SerialName
 import kotlinx.serialization.Serializable
-import kotlinx.serialization.builtins.serializer
-import kotlinx.serialization.descriptors.SerialDescriptor
-import kotlinx.serialization.descriptors.buildClassSerialDescriptor
-import kotlinx.serialization.descriptors.element
-import kotlinx.serialization.encoding.Decoder
-import kotlinx.serialization.encoding.Encoder
-import kotlinx.serialization.encoding.encodeCollection
-import kotlinx.serialization.json.JsonArray
-import kotlinx.serialization.json.JsonDecoder
-import kotlinx.serialization.json.intOrNull
-import kotlinx.serialization.json.jsonArray
-import kotlinx.serialization.json.jsonPrimitive
 
 @Serializable
 data class PackageV1(
@@ -45,36 +32,9 @@ data class PackageV1(
     val nativeCode: List<String>? = null,
     val features: List<String>? = null,
     val antiFeatures: List<String>? = null,
-
-)
-
-@Serializable(PermissionV1Serializer::class)
-data class PermissionV1(
-    val name: String,
-    val maxSdk: Int? = null,
 )
 
-internal class PermissionV1Serializer : KSerializer<PermissionV1> {
-
-    override val descriptor: SerialDescriptor = buildClassSerialDescriptor("PermissionV1") {
-            element<String>("name")
-            element<Int?>("maxSdk")
-        }
-
-    override fun deserialize(decoder: Decoder): PermissionV1 {
-        decoder as? JsonDecoder ?: error("Not a JSON")
-        val array: JsonArray = decoder.decodeJsonElement().jsonArray
-        require(array.size == 2) { "Permission array is invalid: $array" }
-        require(array[0].jsonPrimitive.isString) { "Name is not the first element in permission: $array" }
-        val name: String = array[0].jsonPrimitive.content
-        val maxSdk: Int? = array[1].jsonPrimitive.intOrNull
-        return PermissionV1(name, maxSdk)
-    }
+typealias PermissionV1 = Array<String?>
 
-    override fun serialize(encoder: Encoder, permission: PermissionV1) {
-        encoder.encodeCollection(JsonArray.serializer().descriptor, 2) {
-            encodeStringElement(descriptor, 0, permission.name)
-            encodeNullableSerializableElement(descriptor, 1, Int.serializer(), permission.maxSdk)
-        }
-    }
-}
+val PermissionV1.name: String get() = first()!!
+val PermissionV1.maxSdk: Int? get() = getOrNull(1)?.toInt()