Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should register on main event by-demand #6

Open
DrMerfy opened this issue Jan 2, 2021 · 0 comments
Open

Should register on main event by-demand #6

DrMerfy opened this issue Jan 2, 2021 · 0 comments
Assignees

Comments

@DrMerfy
Copy link
Owner

DrMerfy commented Jan 2, 2021

Because of this lines

vscode-overtype/src/extension.ts

Lines 17 to 18 in cb4d5c6

vscode.commands.registerCommand("type", typeCommand),
vscode.commands.registerCommand("paste", pasteCommand),
this extension subscribes to that events

therefore, this check fails

https://github.com/Microsoft/vscode/blob/d4edb9abcc261846cabee6702715fe2914ae42cb/src/vs/workbench/api/node/extHostCommands.ts#L63-L65

resulting in this bug, for example lucax88x/CodeAceJumper#24

related: microsoft/vscode#13441

solution: register type command only when entering into overwrite mode

Original Issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant