Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Modal 组件命令式调用时 LocaleProvider 没有正常工作 #1301

Open
1 task done
SyMind opened this issue Nov 25, 2022 · 2 comments · May be fixed by #1300
Open
1 task done

[BUG] Modal 组件命令式调用时 LocaleProvider 没有正常工作 #1301

SyMind opened this issue Nov 25, 2022 · 2 comments · May be fixed by #1300

Comments

@SyMind
Copy link
Contributor

SyMind commented Nov 25, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Which Component

Modal

Semi Version

latest

Current Behavior

取消按钮和确认按钮文案为中文。

Expected Behavior

取消按钮和确认按钮文案为英文。

Steps To Reproduce

官网中的例子就是错误的。
链接：https://semi.design/en-US/show/modal#Confirm%20Modal

ReproducibleCode

No response

Environment

- OS:
- browser:

Anything else?

No response
@SyMind SyMind linked a pull request Nov 25, 2022 that will close this issue
Open
15 tasks
@pointhalo
Copy link
Collaborator

image

#387

@SyMind
Copy link
Contributor Author

SyMind commented Nov 25, 2022 •
edited
Loading

@pointhalo 相关的组件库都处理了，这关乎开发体验，没有理由不做。

antd

地址：https://ant.design/~demos/components-modal-demo-hooks
image
代码：https://github.com/ant-design/ant-design/blob/master/components/modal/confirm.tsx#L57

arco

地址：https://arco.design/react/en-US/components/modal#Confirm-Modal
image
代码：https://github.com/arco-design/arco-design/blob/main/components/Modal/confirm.tsx#L76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: local provider not working when confirming modal SyMind/semi-design
2 participants
@SyMind @pointhalo