Update SA1003 and SA1008 to not require space before a cast inside a range expression #3409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inside a range expression
… inside a range expression
Codecov Report
@@ Coverage Diff @@
## master #3409 +/- ##
==========================================
- Coverage 93.15% 93.09% -0.06%
==========================================
Files 1043 1039 -4
Lines 111978 111852 -126
Branches 3973 3969 -4
==========================================
- Hits 104312 104132 -180
- Misses 6645 6702 +57
+ Partials 1021 1018 -3 |
sharwell
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3386.
Note that this false positive was specifically due to the cast. There does not seem to ever be any diagnostic issued for the range in itself, so both
1..2and1 .. 2are ok.