Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetMaxCapacity overwrite on second call. #149

Closed
PodeCaradox opened this issue Dec 29, 2021 · 1 comment
Closed

Add SetMaxCapacity overwrite on second call. #149

PodeCaradox opened this issue Dec 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@PodeCaradox
Copy link

Hey Doraku,

first thanks again, i love your ECS framework :D
My problem is i call world.SetMaxCapacity(chunks.Length); every time i load a new Map, but dont create a new world. Somehow the other calls after the first SetMaxCapacity are ignored. Is this intended? :)
grafik

If you read it in time i wish you a happy new Year :)

@Doraku
Copy link
Owner

Doraku commented Jan 2, 2022

This was by design when I added this feature a long time ago, that's why the SetMaxCapacity returns the actual capacity so you would know if the set worked or not. Since then a lot of stuff have changed and I can see this behavior (setting the MaxCapacity only working once for a give component type, and before any component of that type is set) relaxed ;) I will make it so you can change the max capacity if the new value is greater or equals to the current count of components.

If you read it in time i wish you a happy new Year :)

Thanks a lot I hope you had a great new year eve too ^^

@Doraku Doraku added the enhancement New feature or request label Jan 2, 2022
@Doraku Doraku closed this as completed in 4c14178 May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants