Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible run command #1040

Closed
ntjess opened this issue Dec 31, 2024 · 1 comment
Closed

More flexible run command #1040

ntjess opened this issue Dec 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ntjess
Copy link

ntjess commented Dec 31, 2024

What problem will this feature address?

Docker recommends merging files using multiple -f statements to promote modularity and reusability among compose specs. However, Dokploy's run customization can only append statements; it cannot prefix them.

Describe the solution you'd like

Ideally, we can either specify multiple -f <file> options under Compose Path, or to prepend these flags before the up portion of the compose command.

The former results in no configuration found errors on a compose build, and the latter is not supported currently.

Describe alternatives you've considered

  • See above.
  • Alternatively (and most flexibly), a shell script entrypoint defined in the project folder can also be set as an entrypoint to resolve all these issues. It would also help to provide runtime-generated variables like $PWD which are automatically present in a shell, but not when Dokploy is running the deployment.
  • Docker also allows for the COMPOSE_FILE variable to dictate multiple overrides, but it is unclear whether this option is respected by Dokploy. It also doesn't show as extended/overridden services in the previewed compose file.
  • Less flexibly, a single docker-compose-custom.yml file can consist of these lines:
include:
  - docker-compose.yml
  - another-compose-fileyml

This works from the normal command line, but Dokploy raises an error since it can't find a named domain-mapped service (e.g. if you specify that frontend has a port of 5000 in Dokploy's Domains tab, the error will show if you include files like this)

Will you send a PR to implement it?

Maybe, need help

@ntjess ntjess added the enhancement New feature or request label Dec 31, 2024
@ntjess
Copy link
Author

ntjess commented Jan 3, 2025

I think this is solved by a710728

@ntjess ntjess closed this as completed Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant