Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ScatterVisualizer to a mixin #556

Closed
rebeccabilbro opened this issue Aug 10, 2018 · 2 comments
Closed

Convert ScatterVisualizer to a mixin #556

rebeccabilbro opened this issue Aug 10, 2018 · 2 comments
Labels
level: intermediate python coding expertise required type: technical debt work to optimize or generalize code

Comments

@rebeccabilbro
Copy link
Member

rebeccabilbro commented Aug 10, 2018

Describe the solution you'd like
Convert ScatterVisualizer, currently in contrib, into a YB mixin.

Is your feature request related to a problem? Please describe.
Besides ScatterVisualizer many YB visualizers implement some kind of scatterplot:

And it's likely that future visualizers may also require some form of scatterplot. In order to implement these in a more uniform and predictable way, it would be convenient to convert the current ScatterVisualizer, which was recently moved to contrib, into a YB mixin that could both serve as a base for the above visualizers and support future development.

See discussion in #475

@bbengfort bbengfort added type: technical debt work to optimize or generalize code level: intermediate python coding expertise required labels Aug 20, 2018
@bbengfort
Copy link
Member

See also #676 and #677 which both would influence this mixin.

@bbengfort
Copy link
Member

With the DataVisualizer base class I think we've moved past the need for this mixin; or it would have to take a very different form with our detect target type utilities. Closing in favor of a new approach to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level: intermediate python coding expertise required type: technical debt work to optimize or generalize code
Projects
None yet
Development

No branches or pull requests

2 participants