Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(speedups): use ciso8601 for deserializing datetimes from the gateway #656

Closed
onerandomusername opened this issue Jul 25, 2022 · 2 comments
Closed

feat(speedups): use ciso8601 for deserializing datetimes from the gateway #656

onerandomusername opened this issue Jul 25, 2022 · 2 comments
Assignees
@elenakrittik
Labels
feature request Request for a new feature good first issue Good for newcomers
Milestone
disnake v2.6

Comments

@onerandomusername
Copy link
Member

onerandomusername commented Jul 25, 2022 •
edited
Loading

Summary

use ciso8601 for deserializing datetimes from the gateway

What is the feature request for?

The core library

The Problem

If there's a library written in c that does a task that we do often, it makes sense to use it.

The Ideal Solution

use ciso8601

The Current Solution

using datetime.datetime.fromisoformat...

Additional Context

This should be implemented similar to orjon, using try/except imports, and else. This only really needs to change the one method in utils: parse_time.
@onerandomusername onerandomusername added good first issue Good for newcomers feature request Request for a new feature labels Jul 25, 2022
@onerandomusername onerandomusername added this to the disnake v2.6 milestone Jul 25, 2022
@onerandomusername onerandomusername moved this to Todo in disnake Jul 25, 2022
@elenakrittik
Copy link
Contributor

I'd like to work on this

@onerandomusername
Copy link
Member Author

Assigned you

@elenakrittik elenakrittik mentioned this issue Jul 26, 2022
Closed
8 tasks
@onerandomusername onerandomusername closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2022
Repository owner moved this from Todo to Done in disnake Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elenakrittik elenakrittik

Labels
feature request Request for a new feature good first issue Good for newcomers
Projects
disnake
Status: Done
Milestone
disnake v2.6
Development

Successfully merging a pull request may close this issue.

feat(speedups): use ciso8601 for deserializing datetimes from the gateway
2 participants
@onerandomusername @elenakrittik