feat: add support for editing our own application information #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onerandomusername
added
t: enhancement
onerandomusername
force-pushed
the
arielle/edit-app-info
branch
3 times, most recently
from
08019ab
to
a2bf13f
Compare
onerandomusername
force-pushed
the
arielle/edit-app-info
branch
from
a2bf13f
to
880cfde
Compare
shiftinv
reviewed
Nov 14, 2024
Comment on lines
+294
to
+302
| description: Optional[str] = MISSING, | ||
| flags: ApplicationFlags = MISSING, | ||
| icon: Optional[AssetBytes] = MISSING, | ||
| cover_image: Optional[AssetBytes] = MISSING, | ||
| custom_install_url: Optional[str] = MISSING, | ||
| install_params: Optional[InstallParams] = MISSING, | ||
| role_connections_verification_url: Optional[str] = MISSING, | ||
| interactions_endpoint_url: Optional[str] = MISSING, | ||
| tags: Optional[List[str]] = MISSING, |
There was a problem hiding this comment.
Figured this is worth mentioning - most of these fields, other than icon and cover_image, aren't marked as nullable in the documentation.
However considering that they are optional in the application object structure itself, clearly only setting them to null would reset the fields. So I assume this is fine?
Comment on lines
+309
to
+310
|
|
||
| Returns a new :class:`AppInfo` with the updated information. |
There was a problem hiding this comment.
Suggested change
| Returns a new :class:`AppInfo` with the updated information. |
| description: Optional[:class:`str`] | ||
| The application's description. | ||
| flags: Optional[:class:`ApplicationFlags`] | ||
| The application's public flags. |
There was a problem hiding this comment.
should note that this is limited to specific flags only
| icon: |resource_type| | ||
| Update the application's icon asset, if any. | ||
| cover_image: |resource_type| | ||
| Retrieves the cover image on a store embed, if any. |
|
|
||
| .. versionadded:: 2.10 | ||
|
|
||
| Parameters |
There was a problem hiding this comment.
the docstring is missing interactions_endpoint_url
| Raises | ||
| ------ | ||
| HTTPException | ||
| Editing the information failed somehow. |
There was a problem hiding this comment.
Suggested change
| Editing the information failed somehow. | |
| Editing the application information failed. |
| @@ -2372,6 +2372,93 @@ async def application_info(self) -> AppInfo: | |||
| data["rpc_origins"] = None | |||
| return AppInfo(self._connection, data) | |||
|
|
|||
| async def edit_application_info( | |||
There was a problem hiding this comment.
Having the same method on Client seems unnecessary (also not very DRY code :<).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #1172
Implements PATCH
/applications/@mehttps://discord.com/developers/docs/resources/application#edit-current-application
Checklist
pdm lintpdm pyright