CMake warnings

[ColinGilbert]

Hi!

First of all, thanks for this excellent work. I read the source and its quite nice to see clean, thoughtful CMake-script. :)

However on 3.6.2 and perhaps others, the example (which otherwise works fine) offers a slew of warnings and I wanted to tell you:

cmake -DCMAKE_TOOLCHAIN_FILE=~/devel/android-cmake/android.toolchain.cmake ..
CMake Deprecation Warning at /usr/share/cmake/Modules/CMakeForceCompiler.cmake:79 (message):
  The CMAKE_FORCE_C_COMPILER macro is deprecated.  Instead just set
  CMAKE_C_COMPILER and allow CMake to identify the compiler.
Call Stack (most recent call first):
  /home/noob/devel/android-cmake/android.toolchain.cmake:1206 (CMAKE_FORCE_C_COMPILER)
  build/CMakeFiles/3.6.2/CMakeSystem.cmake:6 (include)
  CMakeLists.txt:1 (project)


CMake Deprecation Warning at /usr/share/cmake/Modules/CMakeForceCompiler.cmake:93 (message):
  The CMAKE_FORCE_CXX_COMPILER macro is deprecated.  Instead just set
  CMAKE_CXX_COMPILER and allow CMake to identify the compiler.
Call Stack (most recent call first):
  /home/noob/devel/android-cmake/android.toolchain.cmake:1214 (CMAKE_FORCE_CXX_COMPILER)
  build/CMakeFiles/3.6.2/CMakeSystem.cmake:6 (include)
  CMakeLists.txt:1 (project)


CMake Warning (dev) at /home/noob/devel/android-cmake/android.toolchain.cmake:1670 (if):
  Policy CMP0054 is not set: Only interpret if() arguments as variables or
  keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  Quoted variables like "LIBRARY_OUTPUT_PATH_ROOT" will no longer be
  dereferenced when the policy is set to NEW.  Since the policy is not set
  the OLD behavior will be used.
Call Stack (most recent call first):
  build/CMakeFiles/3.6.2/CMakeSystem.cmake:6 (include)
  CMakeLists.txt:1 (project)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Configuring done
-- Generating done
-- Build files have been written to: /home/noob/devel/android-cmake-example/build

[Discordia]

Ok I'll take a look at it. I'm running 3.6.1 so I guess I have to update. Thanks for the compliment but if you are talking about the cmake scripts in Discordia/android-cmake then credit should go the the original author, because thats just a fork with minimal changes. Here is the original: https://github.com/taka-no-me/android-cmake

[ColinGilbert]

Thanks for the fast reply!

Actually, I was referring to https://github.com/Discordia/android-cmake/blob/master/android.apk.cmake

Upstream is a total mess.

[Discordia]

Ok thats from here: https://github.com/Uroc327Mirrors/pixellight/blob/master/cmake/Android/Apk.cmake