Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake warnings #3

Open
ColinGilbert opened this issue Sep 20, 2016 · 3 comments
Open

CMake warnings #3

ColinGilbert opened this issue Sep 20, 2016 · 3 comments

Comments

@ColinGilbert
Copy link

Hi!

First of all, thanks for this excellent work. I read the source and its quite nice to see clean, thoughtful CMake-script. :)

However on 3.6.2 and perhaps others, the example (which otherwise works fine) offers a slew of warnings and I wanted to tell you:

cmake -DCMAKE_TOOLCHAIN_FILE=~/devel/android-cmake/android.toolchain.cmake ..
CMake Deprecation Warning at /usr/share/cmake/Modules/CMakeForceCompiler.cmake:79 (message):
  The CMAKE_FORCE_C_COMPILER macro is deprecated.  Instead just set
  CMAKE_C_COMPILER and allow CMake to identify the compiler.
Call Stack (most recent call first):
  /home/noob/devel/android-cmake/android.toolchain.cmake:1206 (CMAKE_FORCE_C_COMPILER)
  build/CMakeFiles/3.6.2/CMakeSystem.cmake:6 (include)
  CMakeLists.txt:1 (project)


CMake Deprecation Warning at /usr/share/cmake/Modules/CMakeForceCompiler.cmake:93 (message):
  The CMAKE_FORCE_CXX_COMPILER macro is deprecated.  Instead just set
  CMAKE_CXX_COMPILER and allow CMake to identify the compiler.
Call Stack (most recent call first):
  /home/noob/devel/android-cmake/android.toolchain.cmake:1214 (CMAKE_FORCE_CXX_COMPILER)
  build/CMakeFiles/3.6.2/CMakeSystem.cmake:6 (include)
  CMakeLists.txt:1 (project)


CMake Warning (dev) at /home/noob/devel/android-cmake/android.toolchain.cmake:1670 (if):
  Policy CMP0054 is not set: Only interpret if() arguments as variables or
  keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  Quoted variables like "LIBRARY_OUTPUT_PATH_ROOT" will no longer be
  dereferenced when the policy is set to NEW.  Since the policy is not set
  the OLD behavior will be used.
Call Stack (most recent call first):
  build/CMakeFiles/3.6.2/CMakeSystem.cmake:6 (include)
  CMakeLists.txt:1 (project)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Configuring done
-- Generating done
-- Build files have been written to: /home/noob/devel/android-cmake-example/build
@Discordia
Copy link
Owner

Ok I'll take a look at it. I'm running 3.6.1 so I guess I have to update. Thanks for the compliment but if you are talking about the cmake scripts in Discordia/android-cmake then credit should go the the original author, because thats just a fork with minimal changes. Here is the original: https://github.com/taka-no-me/android-cmake

@ColinGilbert
Copy link
Author

Thanks for the fast reply!

Actually, I was referring to https://github.com/Discordia/android-cmake/blob/master/android.apk.cmake

Upstream is a total mess.

@Discordia
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants