Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute icon upstream? #2

Closed
wincent opened this issue Jul 19, 2021 · 4 comments
Closed

Contribute icon upstream? #2

wincent opened this issue Jul 19, 2021 · 4 comments

Comments

@wincent
Copy link

wincent commented Jul 19, 2021

Absolutely gorgeous icon, @DinkDonk. 😍

Don't know how open @kovidgoyal would be to accepting a contribution upstream, but have you considered sharing this with him?

@andreypopp
Copy link

kovidgoyal/kitty#3310

But the icon is really good looking

@MindTooth
Copy link

It’s really a nice one. 👍🏻

Not sure that it follows the HIG on macOS. One could solve this by supplying a custom icon for just macOS though.

@wincent
Copy link
Author

wincent commented Jul 19, 2021

kovidgoyal/kitty#3310

Ah, that looks pretty conclusive then. Thanks @andreypopp!

@DinkDonk
Copy link
Owner

Thank you @wincent !
I'm very hesitant to create a pull request on design stuff – it's a subjective matter and even though Kitty is pretty new, it still has well known preexisting branding.

I was unaware of the issue @andreypopp mentioned, but that further seals the deal.
The best thing is probably to just let the alternative icons live outside of the main distribution/repo.

@MindTooth – my icon follows the latest MacOS App Icon guidelines, even though they are just guidelines and not rules.
Breaking the rounded rectangle is allowed but should be done subtly as I feel like I have managed:

If you must alter the shape, prefer subtle adjustments that continue to express a rounded rectangle silhouette.
Human Interface Guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants