-
Notifications
You must be signed in to change notification settings - Fork 310
MutationObserverWatcher seems not working on twitter/ui/fetch #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Here is a edge case in Watcher and I don't know if that helps. Watcher use rAF lock to run checks during each run, if a new task scheduled when the rAF lock is locked, it will be ignored. Watcher should run one more time to check if there is any change during the rAF locking (but it doesn't do it currently). Do some DOM change and check if your problem resolved, if it runs the forEach call after you manually do a DOM change, it is the Watcher bug. |
This could be my bad since I realized that in some cases in exception will not visible in firefox console. I tried to replace your's with a more simpler version this afternoon but the problem consists. Then I found that maybe some exception happened but not shown in the console. |
*but you can catch it by 'pause on exception'. |
It's a Firefox bug. See https://bugzilla.mozilla.org/show_bug.cgi?id=1469304 and facebook/react#16605 |
https://github.com/DimensionDev/Maskbook/blob/4d7e551b03ae6dc0f4dc3cdd2753ff1da1a5cf46/src/social-network-provider/twitter.com/ui/fetch.ts#L48\
The length in the image represents how many element selected by this dynamic selector at this time (via

elevate()
). It changed from 0 to 11 but.forEach
only run once.The text was updated successfully, but these errors were encountered: