Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble Status Binary Sensor Not Working #136

Open
XD36JD2015 opened this issue Oct 15, 2024 · 27 comments
Open

Trouble Status Binary Sensor Not Working #136

XD36JD2015 opened this issue Oct 15, 2024 · 27 comments

Comments

@XD36JD2015
Copy link

XD36JD2015 commented Oct 15, 2024

My alarm panel currently has 2 trouble faults, and I noticed that the trouble binary sensor doesn't indicate that the alarm panel has an issue.

Let me know if you need any more info from me, or need me to test changes.

@Dilbert66
Copy link
Owner

Dilbert66 commented Oct 15, 2024

The trouble binary sensor only activates currently for ac and battery issues at this time. For zone statuses, you will see the zone sensor be on for the zone and you will see the ck:[zone>]messages in the zone status (zs) field showing in HA. For example since you have 2 co2 detectors which are currently showing check trouble so you should see ck:15,ck:16 in the zone status field as well as showing zone 15 and zone 16 as on.

Are you saying you would also like to see the trouble sensor show a fault when individual zones are in check mode?

Are the sensors having issues? Not a bad idea to add check zones to the trouble setting criteria. Easy enough to add.

@XD36JD2015
Copy link
Author

Hi, I think it would be a nice feature to have a sensor with a trouble fault to either trigger the fault sensor, or perhaps the check sensor that I remember seeing a while ago. The two CO detectors are having issues, they have reached end of life. triggering the check status. Thanks for your help!

@Dilbert66
Copy link
Owner

Are you currently seeing the ck:15 and ck:16 in the zone status field on home assistant? You should be. You should also be seeing the fault sensor being shown on for those two zones? If not then I also need to look at that. I've enabled showing the trouble sensor for zone issues and pushed to dev.

@XD36JD2015
Copy link
Author

Hi, sorry for the delay in response. I am seeing ck:16 in the zone status(I replaced the failed sensor in zone 15. I tried(today) to install the latest version of your code from the dev branch, but I am running into compile errors.
Screenshot_20241028-143938
Screenshot_20241028-143912

Also, I am noticing a quirk where the binary sensors for armed_stay and armed_away do not work when there is a trouble fault (ck:16). The ready binary sensor works fine. Let me know if you need more information from me.

@Dilbert66
Copy link
Owner

Dilbert66 commented Oct 28, 2024

Change the "return vista.keybusConnected" in your yaml line to:

     return $panelId->connected();

As to the armed away flag issue, I'll have to see if it happens on my system.

Edit: The armed away and arm binary sensors work fine here even with ck:xx messages showing with this version anyhow.
You might also want to do a "clean" first before a new compile to ensure everything compiles properly. That second error might be due to that.

@XD36JD2015
Copy link
Author

I fixed the .yaml error, still getting this:

Screenshot_20241028-155259

@Dilbert66
Copy link
Owner

Dilbert66 commented Oct 28, 2024

I have no idea why you are getting that error. There is something messed up with your build environment somewhere.

You might want to check that you are compiling the dev version as well as that has a lot of fixes:

external_components:
  - source: github://Dilbert66/esphome-components@dev 

@XD36JD2015
Copy link
Author

I should be pulling from that repo:

Screenshot_20241028-160242

@Dilbert66
Copy link
Owner

Dilbert66 commented Oct 28, 2024

Arghhhh. You are doing it right... My fault. I just checked and found that I had not pushed an old fix to git so the errored version was still there. I'll push a fix in couple minutes. Sorry about that.

Edit: ok , i've pushed the correct file.

@XD36JD2015
Copy link
Author

XD36JD2015 commented Oct 28, 2024

No worries. I recompiled using the newest version of what you have uploaded. The trouble binary is still showing false, and the armed away and armed stay binaries are still showing false when the system is armed and the trouble faults are active. I've also noticed now that when I arm my panel, I am getting two "armed stay" messages from my keypads.

image
image

@Dilbert66
Copy link
Owner

What panel do you have? I don't have the same hardware available so never tested issues with CO sensors. I see the issue as to why the armed sensors are not showing correctly as the flags are slightly different for those. I'll see if I can amend the code to support your version.

@XD36JD2015
Copy link
Author

Hi, I've got a Vista 20p.

@Dilbert66
Copy link
Owner

Dilbert66 commented Oct 28, 2024

Must be a later revision than mine. I have an old ADT branded panel version. Your panel behaviour is slightly different then mine and others i've seen in how it sends out status. Namely, it's missing a system flag that I was dependent on. I'll tweak the handling a bit and see what I can come up with.

@Dilbert66
Copy link
Owner

Can you provide a log sample of open/faulted zones as well. I need to see what flags it sends for those. Tks!

@Dilbert66
Copy link
Owner

Dilbert66 commented Oct 29, 2024

I've pushed a newer version that add ssupport for your panel. It should automatically detect the flag type and adjust accordingly.

@XD36JD2015
Copy link
Author

XD36JD2015 commented Oct 29, 2024

Here is a log with me opening and closing doors as you requested. I'll try out your changes and report back.

@XD36JD2015
Copy link
Author

Just installed the latest version, both the trouble binary and the armed stay and away binaries seem to be working now. Thanks for your work on this! I have wireless smoke/heat/freeze sensors, CO sensors, glass break sensors, flood sensors, door sensors and wireless windows sensors if you ever need some log data or need to try something out.

@Dilbert66
Copy link
Owner

Cool. Tks for the offer! I just updated one setting from zone fault capture that should address an issue I found with your version.

@Dilbert66
Copy link
Owner

Dilbert66 commented Oct 30, 2024

Actually, there is one message I would like to see. A disarmed or armed status message that has no check messages associated. Just a normal status. I need to see what the flags are for no check or fault statuses.

@XD36JD2015
Copy link
Author

XD36JD2015 commented Oct 30, 2024

I captured to unarmed/armed events for you with the trouble cleared.

@Dilbert66
Copy link
Owner

Dilbert66 commented Oct 30, 2024

Awesome! Thank you. You might want to remove your access codes from the logs. FYI

@XD36JD2015
Copy link
Author

Good point, I missed that it was in the logs.

@Dilbert66
Copy link
Owner

Also remove the following "F6" cmds as the keys will show up in the data

@Dilbert66
Copy link
Owner

You can remove the files from this issue. I have them downloaded.

@XD36JD2015
Copy link
Author

I was looking at my armed binary sensor (arm_1), and noticed some weird behavior when the trouble alert is active. Doesn't seem to do it when I clear the trouble zone.
Screenshot_20241030-193518

@Dilbert66
Copy link
Owner

I've made a couple tweaks that should address your issue as well as some others. Your panel is not behaving different than others. It's just that I've never seen CO sensors data with error faults and those are handled different by the panel. I've adjusted the code to handle those instances better without conflicting with the other logic.

@XD36JD2015
Copy link
Author

I'll give it a go and let you know how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants