Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYI: Subliminal 2.2.0 can not be used in Fedora and derivatives. #1136

Closed
darkshram opened this issue Jun 25, 2024 · 2 comments · Fixed by #1137
Closed

FYI: Subliminal 2.2.0 can not be used in Fedora and derivatives. #1136

darkshram opened this issue Jun 25, 2024 · 2 comments · Fixed by #1137
Assignees

Comments

@darkshram
Copy link

darkshram commented Jun 25, 2024

For compatibility reasons, Fedora uses virtualenv 20.21.1, which requires platformdirs <4,>=2.4, so Fedora uses platformdirs 3.11.0. Therefore Subliminal 2.2.0 can not be installed/used in Fedora (and many other Linux distributions) because the upgraded requirement to platformdirs >= 4.2. Unfortunately Fedora and derivatives use (and will keep using) platformdirs 3.11.0 to keep compatibility with legacy versions of Python.

Details at https://src.fedoraproject.org/rpms/python-virtualenv. See the comments in python-virtualenv.spec file.

@darkshram darkshram changed the title FYI: Subliminal 4.2.0 can not be used in Fedora and derivatives. FYI: Subliminal 2.2.0 can not be used in Fedora and derivatives. Jun 25, 2024
@ptrcnull ptrcnull self-assigned this Jun 25, 2024
@ptrcnull
Copy link
Collaborator

as we only use PlatformDirs.user_config_path and PlatformDirs.user_cache_dir, i think we can safely drop the requirement to at least platformdirs >= 3

@darkshram
Copy link
Author

I can confirm, Subliminal 2.2.0 works perfectly with platformdirs 3.11.0. Made rpm package replacing platformdirs>=4.2 with platformdirs>=3.11.

sed -i \
    -e "s|platformdirs>=4.2|platformdirs>=3.11|g" \
    PKG-INFO \
    pyproject.toml \
    subliminal.egg-info/PKG-INFO \
    subliminal.egg-info/requires.txt

Tested downloading Spanish subtitles for a random movie from my colection:

subliminal download -l es xxxxxxx.19xx.1080p.BluRay.x264.AAC.mp4
Not using any configuration file.
Collecting videos  [####################################]  100%
1 video collected / 0 video ignored / 0 error
Downloading subtitles  [####################################]  100%
Downloaded 1 subtitle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants