Add time based placeholders for scan/visit templates #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
There's a shutdown over new years, so I don't think we should worry about running scans during it |
Collaborator
Author
|
And even if they were it would be one hell of a coincidence to trigger the discrepancy. The date for the visit should really come from the visit information anyway. |
{ts_hms} for HourMinuteSecond, eg 142117
{ts_ymd} for YearMonthDay, eg 20250221
tpoliaw
force-pushed
the
ts_placeholders
branch
from
01d3868 to
8b696d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ts_hms} for HourMinuteSecond, eg 142117
{ts_ymd} for YearMonthDay, eg 20250221
There is scope for the year in the visit to not match the year in the timestamp
if run exactly at midnight on NYD. If this is deemed likely enough to be an
issue, we can duplicate the timestamp into the VisitPaths as well as the
ScanPaths.