Linux/AppImage: Install meson and ninja from PyPI #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevilXD
approved these changes
Sep 11, 2024
Some systems (e.g. Ubuntu 22.04, which we use to make the AppImage), have ancient versions of meson and ninja, which is not good when we have dependencies like PyGObject 3.47+ (and more recently, one of its transitive dependencies, pycairo 1.27+) requiring a fairly recent version of meson to be able to be built. So, instead of relying on whatever meson/ninja version the current system provides us with to make the AppImage, this change will simply install up-to-date, official wheels of meson/ninja directly from PyPI. This also allows us to finally unpin PyGObject's version.
|
Yeah, I first tried to pin Then, I learned you could actually install meson/ninja directly from PyPI, which honestly blew my mind... 🤯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the broken "Linux (AppImage)" CI job.
Some systems (e.g. Ubuntu 22.04, which we use to make the AppImage), have ancient versions of meson and ninja, which is not good when we have dependencies like PyGObject 3.47+ (and more recently, one of its transitive dependencies, pycairo 1.27+) requiring a fairly recent version of meson to be able to be built.
So, instead of relying on whatever meson/ninja version the current system provides us with to make the AppImage, this change will simply install up-to-date, official wheels of meson/ninja directly from PyPI.
This also allows us to finally unpin PyGObject's version.