Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change client type to android app #531

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Change client type to android app #531

merged 1 commit into from
Aug 7, 2024

Conversation

Nazar1ky
Copy link
Contributor

@Nazar1ky Nazar1ky commented Aug 5, 2024

No description provided.

@DevilXD
Copy link
Owner

DevilXD commented Aug 5, 2024

Have you tested the login flow with this change? Again, last time the android app client was used, the login flow got protected with the integrity system.

@Nazar1ky
Copy link
Contributor Author

Nazar1ky commented Aug 5, 2024

Have you tested the login flow with this change? Again, last time the android app client was used, the login flow got protected with the integrity system.

Yes, I have tested it, also confirmation here: Windows200000#165 (comment). But please test it too

@biast12
Copy link

biast12 commented Aug 5, 2024

i don't see an issue with the login flow, gonna test it out a bit more to see if it fails (even tho i got a feeling it's not)

@biast12
Copy link

biast12 commented Aug 7, 2024

still haven't gotten an error at all with my PC running for 2 days straight (needed it turned on either way), so i think it's safe to say that it works

@DevilXD
Copy link
Owner

DevilXD commented Aug 7, 2024

While I'm quite pleased that the solution to the issue is so simple, I think going this route without doing anything else, would only result in a quick band-aid fix. The underlying reason for Twitch rejecting the requests, is because the miner makes too many of them in too little amount of time, and I'd rather fix that first, and see where it gets us. I feel it's only a matter of time before the rate limit appears on the android app client ID as well, in which case I'll need to do this optimization anyway.

If that fails, well, then I can merge this. I need to try the other solution first though.

@DevilXD
Copy link
Owner

DevilXD commented Aug 7, 2024

Okay, well, the other client ID just stopped working entirely, so I'll need to just merge this. I'll need to disable the channel status refresh entirely until I can optimize it's GQL access though. Everything should still work, just slightly less efficiently.

@DevilXD DevilXD added the Fix This fixes an existing issue or error label Aug 7, 2024
@DevilXD DevilXD merged commit 25ead72 into DevilXD:master Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix This fixes an existing issue or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants