Inventory not showing completed drops when 'Finished' is checked

[issue-reporter]

The inventory tab is no longer showing completed drops when the 'Finished' option is checked.

This feature used to show all the drops that finished, but recently seems to show nothing. Not sure if it's a bug or a change on Amazon's end, but figured I'd report it just in case.

Thanks for all your hard work, your project has really made Twitch drops something enjoyable again.

[DevilXD]

Hello,

A campaign will be shown as "Finished" only if it hasn't expired yet, and all drops from it have been mined out. In addition to this, none of the other filtering option can cause it to be hidden - to rule this out, you can check all of the filtering options and hit Refresh. Checking all of the options will always show all possible campaigns.

Expired and finished campaigns may sometimes still show in the inventory, but then it's up to Twitch to decide when it's going to disappear - I have no control over this.

Please confirm that you still cannot see them after checking all of the filtering options.

[issue-reporter]

I checked all of the filtering options and searched through the list, and can confirm that no completed campaigns are showing, even ones that are still currently active. I am using the newest build. This issue seemed to appear with a newer build version, I want to say within the past week or so.

When I press 'Reload' on the settings page and swap back to the Inventory tab, I can see it running through all the campaigns and the completed ones do appear momentarily with the rest. Not sure if this helps.

EDIT: I just finished another campaign and it disappeared as well.

[DevilXD]

Hmm. The code responsible for the filtering was touched twice about 2 weeks ago, and one of those touches was making the filter not show sub-only campaigns - those campaigns consist only of drops that can be earned by subscribing to a channel, and thus do not have any time requirements. No time requirement means they take 0 total minutes to mine, and thus also have 0 minutes remaining. This was used to implement the filter: ab37b0a

However, you can see that remaining_time was used for this distinction. That means that any campaign with 0 remaining minutes won't show up. Usually this would be a sub-only campaign, but coincidentally, finished campaigns also have 0 minutes remaining on them, and that's what appears to be filtering them out, even with the filtering option set to show them.

This should be an easy fix to implement.

[DevilXD]

This should be now fixed by bd048e0