Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace prettier check action with our own script #239

Closed
humphd opened this issue Feb 17, 2023 · 3 comments · Fixed by #246
Closed

Replace prettier check action with our own script #239

humphd opened this issue Feb 17, 2023 · 3 comments · Fixed by #246

Comments

@humphd
Copy link
Contributor

humphd commented Feb 17, 2023

The prettier check action we use, creyD/prettier_action, keeps randomly failing:

Run creyD/[email protected]
Run PATH=$(cd $GITHUB_ACTION_PATH; npm bin):$PATH /home/runner/work/_actions/creyD/prettier_action/v4.2/entrypoint.sh
Installing prettier...
Prettifying files...
Files:
/home/runner/work/_actions/creyD/prettier_action/v4.2/entrypoint.sh: line 74: prettier: command not found
Problem running prettier with --check .
Error: Process completed with exit code 1.

Let's replace it with a call to prettier --check adding a script to package.json.

@shawnyu5
Copy link
Contributor

This seems to have started happening recently. There is a bug report on the prettier actions repo. The advantage of using this is its way faster than installing prettier ourselves, and running prettier --check

creyD/prettier_action#113

@shawnyu5
Copy link
Contributor

There seems to be a fix in progress? It seems like the ubuntu image bumped up their npm version, which changed some npm paths. Lets see where this leads.

creyD/prettier_action#112

@humphd
Copy link
Contributor Author

humphd commented Feb 18, 2023

Sounds good, thanks for researching.

Remember the discussion about why I want to pin image/dependency versions? It's because of bugs like this, where a version of npm gets bumped, and causes a chain reaction of failures in other parts of the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants