-
Notifications
You must be signed in to change notification settings - Fork 677
remove endpoint-utils package #8217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f3b8ad6
remove endpoint-utils package
2ffb92d
fix linter
7404cdb
fix: pr comments fixed
3b157f8
fix: tests fixed paths for endpoint utils
e6a9cc4
Update src/utils/endpoint-utils.ts
Bayheck b064843
Update src/configuration/utils.ts
Bayheck 31dd46f
Update src/configuration/utils.ts
Bayheck fc705e4
fix: build error
0605a16
fix pr comments
29f6b5a
Merge branch 'master' into remove-endpoint-utils
Bayheck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/browser/provider/built-in/dedicated/firefox/runtime-info.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,37 @@ | ||
| import { GeneralError } from '../errors/runtime'; | ||
| import { RUNTIME_ERRORS } from '../errors/types'; | ||
| import endpointUtils from 'endpoint-utils'; | ||
| import { | ||
| isMyHostname, getIPAddress, isFreePort, getFreePort, | ||
| } from '../utils/endpoint-utils'; | ||
|
|
||
| export async function getValidHostname (hostname: string): Promise<string> { | ||
| if (hostname) { | ||
| const valid = await endpointUtils.isMyHostname(hostname); | ||
| const valid = await isMyHostname(hostname); | ||
|
|
||
| if (!valid) | ||
| throw new GeneralError(RUNTIME_ERRORS.invalidHostname, hostname); | ||
| } | ||
| else | ||
| hostname = endpointUtils.getIPAddress(); | ||
| else { | ||
| const ip = getIPAddress(); | ||
|
|
||
| if (ip) | ||
| hostname = ip; | ||
| else | ||
| throw new GeneralError(RUNTIME_ERRORS.invalidHostname, hostname); | ||
| } | ||
Bayheck marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| return hostname; | ||
| } | ||
|
|
||
| export async function getValidPort (port: number): Promise<number> { | ||
| if (port) { | ||
| const isFree = await endpointUtils.isFreePort(port); | ||
| const isFree = await isFreePort(port); | ||
|
|
||
| if (!isFree) | ||
| throw new GeneralError(RUNTIME_ERRORS.portIsNotFree, port); | ||
| } | ||
| else | ||
| port = await endpointUtils.getFreePort(); | ||
| port = await getFreePort(); | ||
|
|
||
| return port; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.