update: resize using CDP setWindowBounds #8169
Merged
+101
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I want to provide more information. I reproduced the bug is in Windows: I was not able to reproduce the bug on macOS: Safari, Chrome, Firefox |
PavelMor25
suggested changes
Apr 10, 2024
Contributor
PavelMor25
left a comment
PavelMor25
left a comment
There was a problem hiding this comment.
Please, look at my comments.
src/browser/provider/built-in/dedicated/chrome/cdp-client/index.ts
Outdated
Show resolved
Hide resolved
added 2 commits
April 12, 2024 14:43
PavelMor25
approved these changes
Apr 12, 2024
AlexKamaev
requested changes
Apr 15, 2024
test/functional/fixtures/api/es-next/resize-window/testcafe-fixtures/resize-window-test.js
Show resolved
Hide resolved
src/browser/provider/built-in/dedicated/chrome/cdp-client/index.ts
Outdated
Show resolved
Hide resolved
AlexKamaev
approved these changes
Apr 23, 2024
|
Release v3.6.1-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Describe the problem you want to address or the feature you want to implement.
Approach
Describe how your changes address the issue or implement the desired functionality in as much detail as possible.
References
closes #8157
Pre-Merge TODO