From 66b6209eb47a317b6c6220dfd93d61ef153e07ce Mon Sep 17 00:00:00 2001 From: Bayheck Date: Wed, 28 Feb 2024 18:10:36 +0600 Subject: [PATCH 01/13] testing test-functional-docker workflow --- Gulpfile.js | 1 + 1 file changed, 1 insertion(+) diff --git a/Gulpfile.js b/Gulpfile.js index 3823f828e48..adeb8522673 100644 --- a/Gulpfile.js +++ b/Gulpfile.js @@ -506,6 +506,7 @@ gulp.step('docker-server-test-run', done => { gulp.step('docker-functional-test-run', () => { ensureDockerEnvironment(); + return runFunctionalTestInDocker(PUBLISH_REPO, packageInfo); }); From 9a1ba08b06725cdfb4e61e2d9f07971f967d608d Mon Sep 17 00:00:00 2001 From: Bayheck Date: Wed, 28 Feb 2024 19:29:21 +0600 Subject: [PATCH 02/13] testing --- .../provider/built-in/dedicated/chrome/build-chrome-args.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/provider/built-in/dedicated/chrome/build-chrome-args.js b/src/browser/provider/built-in/dedicated/chrome/build-chrome-args.js index d3b53b23660..915666f141f 100644 --- a/src/browser/provider/built-in/dedicated/chrome/build-chrome-args.js +++ b/src/browser/provider/built-in/dedicated/chrome/build-chrome-args.js @@ -5,7 +5,7 @@ export function buildChromeArgs ({ config, cdpPort, platformArgs, tempProfileDir .concat( cdpPort ? [`--remote-debugging-port=${cdpPort}`] : [], !config.userProfile ? [`--user-data-dir=${tempProfileDir.path}`] : [], - config.headless ? ['--headless'] : [], + config.headless ? ['--headless=new'] : [], config.userArgs ? [config.userArgs] : [], // NOTE: we need to prevent new window blocking for multiple windows in Native Automation isNativeAutomation ? ['--disable-popup-blocking'] : [], From d866668f4b80cf97142a9283dd88b7577dec4990 Mon Sep 17 00:00:00 2001 From: Bayheck Date: Wed, 28 Feb 2024 19:46:42 +0600 Subject: [PATCH 03/13] remove line --- Gulpfile.js | 1 - 1 file changed, 1 deletion(-) diff --git a/Gulpfile.js b/Gulpfile.js index adeb8522673..3823f828e48 100644 --- a/Gulpfile.js +++ b/Gulpfile.js @@ -506,7 +506,6 @@ gulp.step('docker-server-test-run', done => { gulp.step('docker-functional-test-run', () => { ensureDockerEnvironment(); - return runFunctionalTestInDocker(PUBLISH_REPO, packageInfo); }); From 7843656bd087150a37c53eff050c780cbda9381f Mon Sep 17 00:00:00 2001 From: Bayheck Date: Thu, 14 Mar 2024 18:04:02 +0500 Subject: [PATCH 04/13] fix: maximize window test fixed and window-size flag test skipped --- .../testcafe-fixtures/maximize-window-test.js | 15 +++++++++++++-- .../fixtures/regression/gh-3456/test.js | 5 +++-- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/test/functional/fixtures/api/es-next/maximize-window/testcafe-fixtures/maximize-window-test.js b/test/functional/fixtures/api/es-next/maximize-window/testcafe-fixtures/maximize-window-test.js index ce24b4e467c..67f04a94e84 100644 --- a/test/functional/fixtures/api/es-next/maximize-window/testcafe-fixtures/maximize-window-test.js +++ b/test/functional/fixtures/api/es-next/maximize-window/testcafe-fixtures/maximize-window-test.js @@ -14,6 +14,10 @@ const getWindowDimensionsInfo = ClientFunction(() => { }; }); +const isHeadlessChrome = ClientFunction(() => { + return /HeadlessChrome/.test(window.navigator.userAgent); +}); + const INITIAL_SIZE = 500; fixture `Maximize Window` @@ -29,9 +33,16 @@ fixture `Maximize Window` test('Maximize window', async t => { await t.maximizeWindow(); + const isHeadless = await isHeadlessChrome(); const dimensions = await getWindowDimensionsInfo(); - expect(dimensions.outerWidth).to.be.at.least(dimensions.availableWidth); - expect(dimensions.outerHeight).to.be.at.least(dimensions.availableHeight); + if (isHeadless) { + expect(dimensions.innerWidth).to.be.at.least(dimensions.availableWidth); + expect(dimensions.innerHeight).to.be.at.least(dimensions.availableHeight); + } + else { + expect(dimensions.outerWidth).to.be.at.least(dimensions.availableWidth); + expect(dimensions.outerHeight).to.be.at.least(dimensions.availableHeight); + } }); diff --git a/test/functional/fixtures/regression/gh-3456/test.js b/test/functional/fixtures/regression/gh-3456/test.js index 85e38ee3945..c36f24079ee 100644 --- a/test/functional/fixtures/regression/gh-3456/test.js +++ b/test/functional/fixtures/regression/gh-3456/test.js @@ -7,11 +7,12 @@ const assertionHelper = require('../../../assertion-helper.js'); const SCREENSHOTS_PATH = path.resolve(assertionHelper.SCREENSHOTS_PATH); if (config.useLocalBrowsers) { - describe('[Regression](GH-3456) Should process --window-size arg in Headless mode ', function () { + // See chromium issue with --window-size flag in headless https://issues.chromium.org/issues/40256833 + describe.skip('[Regression](GH-3456) Should process --window-size arg in Headless mode ', function () { it(':headless', () => { const browsers = [ 'chrome:headless --window-size=501,602', - 'chrome --headless --window-size=501,602', + 'chrome --headless=new --window-size=501,602', ]; return createTestCafe('127.0.0.1', 1335, 1336) From 4e51375378b90a0eb629f0a0aa82a9ced8289e01 Mon Sep 17 00:00:00 2001 From: Bayheck Date: Tue, 19 Mar 2024 17:02:19 +0500 Subject: [PATCH 05/13] fix: tests fixed --- .../api/es-next/request-hooks/common/mock-routes.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/functional/fixtures/api/es-next/request-hooks/common/mock-routes.js b/test/functional/fixtures/api/es-next/request-hooks/common/mock-routes.js index b72efd03b74..0baf481fa36 100644 --- a/test/functional/fixtures/api/es-next/request-hooks/common/mock-routes.js +++ b/test/functional/fixtures/api/es-next/request-hooks/common/mock-routes.js @@ -1,7 +1,7 @@ const routes = { - main: 'http://one-dummy-url.com', - get: 'http://one-dummy-url.com/get', - post: 'http://one-dummy-url.com/post', + main: 'https://one-dummy-url.com', + get: 'https://one-dummy-url.com/get', + post: 'https://one-dummy-url.com/post', another: 'https://another-dummy-url.com', }; From efc7738b53af1ed4f3534c36298ce033f1fa4e22 Mon Sep 17 00:00:00 2001 From: Bayheck Date: Tue, 19 Mar 2024 18:35:33 +0500 Subject: [PATCH 06/13] fix: request tests --- .../api/es-next/request-hooks/common/mock-routes.js | 10 ++++++---- .../testcafe-fixtures/request-mock/basic.js | 8 ++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/test/functional/fixtures/api/es-next/request-hooks/common/mock-routes.js b/test/functional/fixtures/api/es-next/request-hooks/common/mock-routes.js index 0baf481fa36..0e8c86a518a 100644 --- a/test/functional/fixtures/api/es-next/request-hooks/common/mock-routes.js +++ b/test/functional/fixtures/api/es-next/request-hooks/common/mock-routes.js @@ -1,8 +1,10 @@ const routes = { - main: 'https://one-dummy-url.com', - get: 'https://one-dummy-url.com/get', - post: 'https://one-dummy-url.com/post', - another: 'https://another-dummy-url.com', + main: 'http://one-dummy-url.com', + get: 'http://one-dummy-url.com/get', + post: 'http://one-dummy-url.com/post', + another: 'https://another-dummy-url.com', + secureMain: 'https://secure-dummy-url.com', + secureGet: 'https://secure-dummy-url.com/get', }; export default routes; diff --git a/test/functional/fixtures/api/es-next/request-hooks/testcafe-fixtures/request-mock/basic.js b/test/functional/fixtures/api/es-next/request-hooks/testcafe-fixtures/request-mock/basic.js index ecd28359d46..a016cd2aad2 100644 --- a/test/functional/fixtures/api/es-next/request-hooks/testcafe-fixtures/request-mock/basic.js +++ b/test/functional/fixtures/api/es-next/request-hooks/testcafe-fixtures/request-mock/basic.js @@ -9,7 +9,7 @@ const testPageMarkup = `