feat: added pathPattern parameter to takeScreenshot method #8093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need-response-app
bot
added
the
STATE: Need response
Bayheck
removed
the
STATE: Need response
AlexKamaev
requested changes
Nov 28, 2023
test/functional/fixtures/api/es-next/take-screenshot/testcafe-fixtures/take-screenshot.js
Show resolved
Hide resolved
… custom pathPatterns
AlexKamaev
requested changes
Nov 28, 2023
AlexKamaev
approved these changes
Nov 29, 2023
aleks-pro
requested changes
Nov 29, 2023
Collaborator
aleks-pro
left a comment
aleks-pro
left a comment
There was a problem hiding this comment.
I've got an error, when tried to use pathPattern in '*.ts' test file:
aleks-pro
reviewed
Nov 30, 2023
aleks-pro
approved these changes
Dec 6, 2023
aleks-pro
changed the title
Co-authored-by: Gene <[email protected]>
|
Release v3.5.0-rc.1 addresses this. |
1 similar comment
|
Release v3.5.0-rc.1 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add new a parameter pathPattern to takeScreenshot method. It allows the use of placeholders for specific takeScreenshot calls.
Approach
I added a new parameter pathPattern to TakeScreenshotCommand .
In src/screenshots/capturer.js _capture method retrieve screenshotPath from pathPattern.
Show warning if both path and pathPattern present.
References
close #8086
Pre-Merge TODO