Positioning to multiline elements #3004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bayheck
changed the title
2 tasks
Aleksey28
approved these changes
May 22, 2024
PavelMor25
approved these changes
May 22, 2024
Aleksey28
requested changes
May 29, 2024
Collaborator
Aleksey28
left a comment
Aleksey28
left a comment
There was a problem hiding this comment.
Great, look at my comment please
Aleksey28
approved these changes
May 29, 2024
|
Release v31.7.2 addresses this. |
Aleksey28
pushed a commit
to DevExpress/testcafe
that referenced
this pull request
Jun 3, 2024
<!-- Thank you for your contribution. Before making a PR, please read our contributing guidelines at https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution We recommend creating a *draft* PR, so that you can mark it as 'ready for review' when you are done. --> ## Purpose Testcafe did not click properly on multiline elements. ## Approach In testcafe-hammerhead replaced getBoundingClientRect with getClientRects. Fix Edge workflow tests #8189 ## References #8179 #8148 Hammerhead PR: DevExpress/testcafe-hammerhead#3004 ## Pre-Merge TODO - [x] Write tests for your proposed changes - [ ] Make sure that existing tests do not fail --------- Co-authored-by: Bayheck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
getBoundingClientRect does not return border boxes of each mutiline element.
Approach
Replace getBoundingClientRect with getClientRects
References
DevExpress/testcafe#8183
Pre-Merge TODO