fixed: Sockets hanging (closes #7097) #2976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
PavelMor25
changed the title
AlexKamaev
approved these changes
Nov 14, 2023
aleks-pro
reviewed
Nov 14, 2023
aleks-pro
requested changes
Nov 14, 2023
aleks-pro
approved these changes
Nov 15, 2023
AlexKamaev
pushed a commit
to DevExpress/testcafe
that referenced
this pull request
Nov 20, 2023
Test for [PR testcafe-hammerhead](DevExpress/testcafe-hammerhead#2976) ## Pre-Merge TODO - [ ] Write tests for your proposed changes - [ ] Make sure that existing tests do not fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Due to changes in Node.js, the old approach of destroying the request is no longer suitable, as the check within the method itself determines that it has already been destroyed.
Approach
We have added a
closeConnectionOnErrormethod inRequestPipelineContextthat bypasses this check.References
issue 7097
Pre-Merge TODO