Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: updating multiple flakes in the same repo in the same PR #82

Open
ipetkov opened this issue Aug 27, 2023 · 3 comments
Open

Comments

@ipetkov
Copy link

ipetkov commented Aug 27, 2023

Sometimes it is useful to create a secondary sub-flake which contains tests and their related dependencies so that they are not included in the top-level flake consumed downstream (i.e. to avoid polluting others' lock files with development dependencies).

It would be useful if the update-flake-lock action could update the root and sub flake in the same run/opened-PR and keep all inputs moving in lock step, rather than doing it across multiple runs

@srid
Copy link

srid commented Mar 18, 2024

Here's a real-world use case, if maintainers are looking for one. I have 4 example flakes in this repo, and would like to (after adding a flake.lock to each) a single Github Action workflow that will update all 4 of them at the same time.

If I'm to use DeterminateSystems/update-flake-lock in its current state, I'll have no choice but to create 4 different workflows which is just an overkill.

@srid
Copy link

srid commented May 26, 2024

Another example: services-flake which currently updates 4 lock files:

image

This ends up creating 4 PRs every week:

image

@shivaraj-bh
Copy link

Another example: services-flake which currently updates 4 lock files:

image This ends up creating 4 [PRs](https://github.com/juspay/services-flake/pulls?q=is%3Apr+%22Update+lock%22) every week: image

Multiple workflow files is now replaced with a single file using github actions’ matrix: https://github.com/juspay/services-flake/blob/43073cea552aacd62ceebd83e0e835cd17e48f34/.github/workflows/update-flake-lock.yaml

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants