Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include upstream git log in PR description, possibly even filtered? #65

Open
nomeata opened this issue Feb 28, 2023 · 1 comment
Open

Comments

@nomeata
Copy link

nomeata commented Feb 28, 2023

This action looks like it’s the natural replacement for https://github.com/knl/niv-updater-action when moving from niv to flakes.

One feature that I like a lot about niv-updater-actions is that it includes the relevant bits from the upstream git changelog in the PR description (and, somewhat related, it keeps updating the same PR until it can get merged, so if merging takes longer it will not create many PRs).

(It munges the changelog so that commit and PR references point to the right repo, and that they don’t spam upstream PRs with “this PR has been mentioned”.)

Would this be a useful feature for update-flake-lock as well?

If so, a possible (optional) extension would be to only lists those upstream commits that actually changed the derivation of the current flake’s outputs – useful when upstream has lots of unrelated changes, as nixpkgs tends to do, as outlined in https://discourse.nixos.org/t/bumping-flake-inputs-bisecting-input-repo-for-relevant-changelog-entries/25619/7?u=nomeata.

@tlvince
Copy link

tlvince commented Dec 21, 2023

A quick and dirty way of doing this could be to interpret the commit diff to leverage GitHub's compare commits feature, e.g. compare.js, example PR: tlvince/nixos-config#33.

Rather than RegEx, a better way would be to hook into nix flake update directly. Could it produce an AST? Failing that, parsing flake.lock (since it's just JSON) could work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants