Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated decorator doesn't work with overload and contextmanager decorators #859

Open
DetachHead opened this issue Nov 8, 2024 · 0 comments
Labels
type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules upstream bug a bug that also exists in pyright but has not been raised upstream

Comments

@DetachHead
Copy link
Owner

Code sample in basedpyright playground

from contextlib import contextmanager
from typing import overload
from warnings import deprecated
from collections.abc import Iterator


@contextmanager
@deprecated("asdf")
@overload
def foo() -> Iterator[None]: ...

@contextmanager
@deprecated("asdf")
@overload
def foo(value: int) -> Iterator[None]: ...


@contextmanager
def foo(value: int | None = None) -> Iterator[None]: #pyright:ignore[reportUnusedParameter]
    yield


_ = foo() # no error
_ = foo(1) # no error
@DetachHead DetachHead added type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules upstream bug a bug that also exists in pyright but has not been raised upstream labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type checking / linting issues relating to existing diagnostic rules or proposals for new diagnostic rules upstream bug a bug that also exists in pyright but has not been raised upstream
Projects
None yet
Development

No branches or pull requests

1 participant