Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Disabling the extension wont actually disable highlighting #3

Closed
Derpius opened this issue Feb 14, 2022 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@Derpius
Copy link
Owner

Derpius commented Feb 14, 2022

Describe the bug
Due to the way the language server loads EmmyLua extensions via the config, and due to not being able to edit the config during the deactivate event, it's currently impossible (to my knowledge) to actually remove the bindings automatically when disabling/uninstalling the extension

I have however added code to disable the extension from deactivate in the event that this limitation is removed

To Reproduce
Steps to reproduce the behaviour:

  1. Install the extension
  2. Open a Lua file
  3. Disable the extension and reload vscode
  4. The bindings are still active

Expected behaviour
The extension would disable its bindings on deactivation

Additional context
microsoft/vscode#45474
Ketho/vscode-wow-api#20

@Derpius Derpius added the bug Something isn't working label Feb 14, 2022
@Derpius
Copy link
Owner Author

Derpius commented Aug 9, 2022

This should actually be fixed in the new version of the extension, as it removes the annotations file on deactivate

@Derpius Derpius closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant