Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] implement optional chaining as now has full support #452

Open
DerekNonGeneric opened this issue Jun 23, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed pending-triage

Comments

@DerekNonGeneric
Copy link
Owner

Seems like we should be using optional chaining syntax (?.) in the loader source code now that it is stage 4 and well-supported. At the time when this was written, that language feature was relatively new and not yet generally available.

See:

if (typeof original === 'function') {
module.exports.default = function() {
return original.apply(this, arguments);
};
} else {
module.exports.default = original;

@DerekNonGeneric DerekNonGeneric added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 23, 2023
@DerekNonGeneric
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed pending-triage
Projects
None yet
Development

No branches or pull requests

1 participant