Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi server support #7

Open
DerTyp7 opened this issue Oct 27, 2022 · 9 comments
Open

Multi server support #7

DerTyp7 opened this issue Oct 27, 2022 · 9 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@DerTyp7
Copy link
Owner

DerTyp7 commented Oct 27, 2022

Right now, if you connect to another server, the overlay will crash.

Change this to support multiple connections.

Try to always show the server which the user is currently active in.
Alternatively, use the first server the user connected to.

@DerTyp7 DerTyp7 added bug Something isn't working enhancement New feature or request labels Oct 27, 2022
@DerTyp7 DerTyp7 closed this as completed Jun 28, 2023
@LeonMarcel-HD
Copy link

LeonMarcel-HD commented Jun 28, 2023

The Overlay seems to not update when you switch the tab in the TeamSpeak Client. Or is it only intended to switch when you can talk on the other server?

@DerTyp7
Copy link
Owner Author

DerTyp7 commented Jun 28, 2023

The Overlay seems to not update when you switch the tab in the TeamSpeak Client. Or is it only intended to switch when you can talk on the other server?

Should switch when you switch the active tab.

TeamSpeak doesn't give feedback when you switch tabs, so I use the "clientSelfPropertyUpdated" event. This event is triggered when the microphone is unmuted when switching tabs (In TS5, the hardware microphone is always muted when you have another server open). So it's kind of a workaround.

So, correctly expressed, the server on which the hardware input was last unmuted is the active server.

ezgif com-video-to-gif

@DerTyp7
Copy link
Owner Author

DerTyp7 commented Jun 28, 2023

There is one problem: when you connect to a new server, you have to switch back and forth once (because of the hardware input workaround).

ezgif com-video-to-gif (2)

@LeonMarcel-HD
Copy link

There is a TeamSpeak setting which automatically mutes and unmutes you depending on which tab is currently visible. Since I had that disabled and since a few updates it is no longer on by default I was a bit confused. But if I remember correctly the client should give you some kind of update when the active tab is switched. (Need to check that later today)

@DerTyp7
Copy link
Owner Author

DerTyp7 commented Jun 29, 2023

hope we find a better solution

@DerTyp7 DerTyp7 reopened this Jun 29, 2023
@DerTyp7
Copy link
Owner Author

DerTyp7 commented Jun 29, 2023

The only extra event i get is the serverPropertiesUpdated event, but they don't seem to make sense.

I switched between two different servers and got an event with the same connectionId (4).
I don't really know what I could read out of this.

image
(I console.log all WS-Events I get by TS)

@DerTyp7 DerTyp7 added the help wanted Extra attention is needed label Jun 29, 2023
@DerTyp7
Copy link
Owner Author

DerTyp7 commented Jun 29, 2023

I noticed that the auth payload sent by TeamSpeak gives me a currentConnectionId, but this seems to be always 0.

If I would get the correct connectionId and not just 0, I could "reauth" every time I get a serverPropertiesChangeEvend and update the clients.

image

@LeonMarcel-HD
Copy link

The serverPropertiesUpdated event is sent, when you click onto the server in the server tree, so that you get the Server Name, Banner, Button and the options to edit the Server on the right. Now when switching the Tab, it only logs an serverPropertiesUpdated, when the Server is selected at the top, if the client is selected it wont get triggered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants